[FSADT1-1021] Remove "All fields are required" and add "(required)" to all input field labels #661

fterra-encora · 2023-12-07T15:56:20Z

Description

Removes "All fields are required"
Adds "(required)" to all input field labels

Fixes FSADT1-1021

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist

I have read the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

github-actions · 2023-12-07T15:56:39Z

Current changelog

Bug Fixes

FSADT1-1049: fixing a loop condition on contact creation (#663) (dd42d8e)

Features

add "required" to fields in the Address step (c359383)
add "required" to fields in the Business step (7bdb19a)
add "required" to fields in the Contacts step (66e82d3)
add require-label to the AutoComplete input component (d0a6031)
add require-label to the Radio input component (6d9c07b)
remove instruction message (d53c439)

github-actions · 2023-12-07T15:57:01Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

github-actions · 2023-12-07T18:33:56Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

…text in step 2 (#662) * feat: move the country field * feat: change instruction message --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>

github-actions · 2023-12-07T19:02:57Z

Overall Project	NaN% `NaN%`	🍏

There is no coverage information present for the Files changed

sonarcloud · 2023-12-07T19:07:17Z

[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

87.5% Coverage
0.0% Duplication

github-actions · 2023-12-07T19:07:23Z

Frontend unit Test Coverage

Coverage after merging feat/FSADT1-1021 into main will be

55.77%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	48.39%	50%	0%	68.42%	108, 36, 39–40, 44, 52–53, 62
directivesMap.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	85%	60%	83.33%	95.83%	33–35, 50, 55
MainHeaderComponent.vue	79.69%	76.56%	58.33%	88.46%	100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
src/components/forms
AutoCompleteInputComponent.vue	75.37%	58.14%	80.95%	84.29%	111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
DropdownInputComponent.vue	90.10%	87.10%	83.33%	94.23%	111, 136, 67, 81, 81, 81–82
MultiselectInputComponent.vue	92.55%	91.67%	85.71%	95.92%	100, 109, 80, 89
RadioInputComponent.vue	87.50%	85.71%	75%	93.33%	39, 44, 80, 89
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	87.84%	81.82%	84.62%	92.31%	122, 130, 55, 84, 89–90, 98
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	81.32%	75.28%	75%	86.18%	137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 450, 460, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	1.22%	0%	0%	2.73%	104–105, 107, 107, 107, 111–112, 114–115, 115, 115, 115, 117, 124, 131, 140–141, 141, 141, 141, 143, 145, 147, 151, 153–154, 154, 154–155, 155, 155, 155, 157, 159, 161, 164, 168–169, 169, 169, 169, 171, 173, 175, 179–180, 180, 180, 183, 185–186, 186–187, 187, 189, 19, 192, 194–196, 196, 196, 196, 196–198, 206, 208–209, 212, 214, 219–220, 220, 220–225, 225, 225–227, 230, 234–235, 235, 235–236, 248, 248, 248, 255, 255, 255–256, 256, 256–257, 257, 261, 261, 261, 273, 273, 273–274, 274, 28, 280, 280, 280, 282, 282, 282–283, 283, 283, 285, 285, 293, 293, 293, 301, 301, 301–302, 302, 302, 306, 306, 306, 323, 323, 323–324, 324, 324, 338, 338, 338, 34, 340, 340, 340, 35, 351, 351, 351, 354, 354, 354–355, 355, 355, 359, 359, 361, 361, 361, 37, 40, 42, 42, 42, 46, 46, 46, 49–51, 53–54, 57, 61–63, 66–68, 72, 76, 76, 76, 76, 76, 76–77, 82, 84, 87–88, 88, 88, 88, 88–89, 92, 95
ContactGroupComponent.vue	67.18%	83.33%	46.67%	64.15%	100, 114, 120, 137, 145, 154, 161, 170, 177, 185, 193, 201, 215, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91, 99, 99, 99
ErrorNotificationGroupingComponent.vue	74.67%	62.86%	57.14%	90.91%	110, 117, 117, 117, 121, 129, 129, 138, 150, 175, 175, 58, 63, 81, 90, 98
src/composables
useFetch.ts	90.77%	73.68%	100%	97.56%	117, 121, 130, 17, 51, 88
useFocus.ts	25.93%	6.67%	30%	34.48%	28, 28, 28–30, 30, 30–32, 34, 44, 49–50, 50, 50, 53, 53, 53, 55–57, 63, 63, 63, 66–67, 70, 85, 85, 85, 92, 95, 98
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	21.43%	13.04%	50%	22.22%	10, 17–18, 18, 18–19, 19, 19–21, 21, 21–22, 24, 27, 27, 27–28, 35–36, 36, 36–37, 43–45, 45, 45–48, 5, 5–7, 7, 7–8, 8, 8–9
DataConversors.ts	75.61%	79.17%	50%	73.33%	33, 38, 38, 38, 38, 38–39, 4, 41

github-actions · 2023-12-07T19:07:25Z

Frontend component Test Coverage

Coverage after merging feat/FSADT1-1021 into main will be

92.95%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	100%	100%	100%	100%
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	100%	100%	100%	100%
UserProfileComponent.vue	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	92.19%	89.19%	85.71%	95.71%	179, 208, 41, 47, 68, 81, 83
DropdownInputComponent.vue	91.67%	92.31%	83.33%	94.23%	111, 136, 81, 81–82
MultiselectInputComponent.vue	90.11%	80.95%	85.71%	95.92%	100, 109, 122, 41, 47, 89
RadioInputComponent.vue	100%	100%	100%	100%
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	90.14%	84.21%	84.62%	94.87%	122, 130, 148, 55, 98
src/components/forms/DateInputComponent
DateInputPart.vue	100%	100%	100%	100%
common.ts	100%	100%	100%	100%
index.vue	100%	100%	100%	100%
src/components/grouping
AddressGroupComponent.vue	89.67%	89.89%	90.70%	89.09%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 261, 306, 361
ContactGroupComponent.vue	91.41%	95.56%	90%	88.68%	100, 137, 209, 215, 84, 91, 99, 99
ErrorNotificationGroupingComponent.vue	100%	100%	100%	100%
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	100%	100%	100%	100%
FormBCSCPage.vue	100%	100%	100%	100%
FormBCeIDPage.vue	100%	100%	100%	100%
FormSubmittedPage.vue	100%	100%	100%	100%
LandingPage.vue	100%	100%	100%	100%
NotFoundPage.vue	100%	100%	100%	100%
SubmissionListPage.vue	100%	100%	100%	100%
SubmissionReviewPage.vue	100%	100%	100%	100%
UserLoadingPage.vue	100%	100%	100%	100%
src/pages/bceidform
AddressWizardStep.vue	100%	100%	100%	100%
BusinessInformationWizardStep.vue	100%	100%	100%	100%
ContactWizardStep.vue	100%	100%	100%	100%
ReviewWizardStep.vue	100%	100%	100%	100%
src/services
ForestClientService.ts	100%	100%	100%	100%

github-actions · 2023-12-07T19:07:27Z

Frontend e2e Test Coverage

Coverage after merging feat/FSADT1-1021 into main will be

72.74%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	83.87%	75%	50%	100%	62
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	47.58%	50%	8.33%	53.85%	100, 107, 122, 134, 141, 150, 173, 173–174, 174–175, 175–176, 176, 185, 185, 185, 197, 197, 197, 201, 217, 217, 217, 230, 249, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
UserProfileComponent.vue	30%	0%	0%	42.86%	11–12, 15, 17, 17, 17, 17, 19, 21, 23, 4
src/components/forms
AutoCompleteInputComponent.vue	92.97%	91.89%	85.71%	95.71%	179, 208, 47, 68, 81, 83
DropdownInputComponent.vue	96.88%	96.15%	94.44%	98.08%	111, 136
MultiselectInputComponent.vue	90.11%	80.95%	85.71%	95.92%	100, 109, 122, 41, 47, 89
RadioInputComponent.vue	88.89%	75%	83.33%	96.67%	39, 49, 80, 91
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	92.96%	84.21%	92.31%	97.44%	122, 130, 148, 55
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	83.86%	74.29%	93.75%	86.18%	108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	89.67%	89.89%	90.70%	89.09%	115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 261, 306, 361
ContactGroupComponent.vue	98.44%	100%	100%	96.23%	84, 91
ErrorNotificationGroupingComponent.vue	38.03%	12.90%	57.14%	57.58%	110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 164, 175, 175, 175, 175, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 98, 98
src/composables
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	25%	100%	100%	25%	11–12, 2
FormBCSCPage.vue	83.41%	66.67%	71.88%	91.97%	120–121, 134, 204, 264, 266, 275, 290–292, 315, 315, 315, 317–318, 323, 364, 455, 477, 49–51, 513, 513, 513, 62, 79
FormBCeIDPage.vue	56.17%	49.35%	33.33%	66.40%	110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 279, 279–284, 298, 298–299, 304, 304–305, 305–306, 306, 311, 317–318, 320, 320–322, 327–328, 337, 340–344, 354, 354, 356–358, 429, 459, 459, 459, 476, 476, 476, 524, 527, 527, 527, 546, 68–70, 89, 93–94, 96, 99
FormSubmittedPage.vue	61.11%	25%	0%	83.33%	12, 30, 32, 32, 32
LandingPage.vue	75%	42.86%	100%	92.31%	18, 18–19, 48, 58
SubmissionListPage.vue	8.05%	0%	0%	12.73%	103–105, 137, 153, 153, 178, 178, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
SubmissionReviewPage.vue	19.92%	0%	0%	40.17%	101, 103–105, 114, 114–115, 115, 120–121, 121–124, 128, 128, 142, 148–151, 151, 151–152, 154, 157, 160–161, 161–163, 166–167, 167–168, 170–171, 171–172, 175–176, 176–177, 177, 177–178, 181–182, 182, 182, 182, 182, 184, 186, 188, 190, 216, 216, 221, 221, 233, 233, 233, 233, 245, 245, 245, 245, 245, 268, 268, 268, 268, 268, 277, 277, 286, 32, 35–36, 384, 384, 39, 418, 418, 454, 454, 454–455, 455, 455,

fterra-encora added 6 commits December 7, 2023 12:32

feat: remove instruction message

d53c439

feat: add require-label to the AutoComplete input component

d0a6031

feat: add require-label to the Radio input component

6d9c07b

feat: add "required" to fields in the Business step

7bdb19a

feat: add "required" to fields in the Address step

c359383

feat: add "required" to fields in the Contacts step

66e82d3

fterra-encora requested review from paulushcgcj and mamartinezmejia as code owners December 7, 2023 15:56

fterra-encora had a problem deploying to dev December 7, 2023 15:59 — with GitHub Actions Failure

Merge branch 'main' into feat/FSADT1-1021

a9409aa

paulushcgcj had a problem deploying to dev December 7, 2023 18:36 — with GitHub Actions Failure

paulushcgcj temporarily deployed to dev December 7, 2023 18:43 — with GitHub Actions Inactive

paulushcgcj temporarily deployed to dev December 7, 2023 18:49 — with GitHub Actions Inactive

fterra-encora and others added 2 commits December 7, 2023 11:02

[FSADT1-1022] Move Country dropdown and update "Add another address" …

6dbcae9

…text in step 2 (#662) * feat: move the country field * feat: change instruction message --------- Co-authored-by: Paulo Gomes da Cruz Junior <[email protected]>

Merge branch 'main' into feat/FSADT1-1021

2a6c42a

paulushcgcj approved these changes Dec 7, 2023

View reviewed changes

paulushcgcj temporarily deployed to dev December 7, 2023 19:05 — with GitHub Actions Inactive

paulushcgcj temporarily deployed to dev December 7, 2023 19:12 — with GitHub Actions Inactive

paulushcgcj merged commit faa73a1 into main Dec 7, 2023
18 checks passed

paulushcgcj deleted the feat/FSADT1-1021 branch December 7, 2023 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FSADT1-1021] Remove "All fields are required" and add "(required)" to all input field labels #661

[FSADT1-1021] Remove "All fields are required" and add "(required)" to all input field labels #661

fterra-encora commented Dec 7, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

sonarcloud bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

[FSADT1-1021] Remove "All fields are required" and add "(required)" to all input field labels #661

[FSADT1-1021] Remove "All fields are required" and add "(required)" to all input field labels #661

Conversation

fterra-encora commented Dec 7, 2023 • edited by github-actions bot Loading

Description

Type of change

How Has This Been Tested?

Checklist

Further comments

github-actions bot commented Dec 7, 2023 • edited Loading

Current changelog

Bug Fixes

Features

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

sonarcloud bot commented Dec 7, 2023

github-actions bot commented Dec 7, 2023

Frontend unit Test Coverage

github-actions bot commented Dec 7, 2023

Frontend component Test Coverage

github-actions bot commented Dec 7, 2023

Frontend e2e Test Coverage

fterra-encora commented Dec 7, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Dec 7, 2023 •

edited

Loading