Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSADT1-1058] BCSC form breakpoints #676

Merged
merged 8 commits into from
Dec 14, 2023
Merged

[FSADT1-1058] BCSC form breakpoints #676

merged 8 commits into from
Dec 14, 2023

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Dec 13, 2023 •
edited by github-actions bot
Loading

Description

Adjust breakpoint styles for the BCSC form.
Most notably for the Small breakpoint regarding the following items:

  • The read-only section;
  • All the confirmation modals.

Apart from the Small breakpoint, the confirmation modals were updated for all other breakpoints to a fixed width of 40 rem (640 pixels). And this includes all the pages: BCSC form, BCeID form and Review new client.

Fixes FSADT1-1058

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

Current changelog

Bug Fixes

  • adjust inline notification style (e38d6b0)
  • adjust modal and button breakpoints (bd876f8)
  • adjust modal width (46cbbd3)
  • adjust read-only cards breakpoints (5d3c725)
  • fix width of read-only cards (d35bab9)
  • sec: fixing possible security hotspot (2ed1efe)
  • tweek notification and confirmation (1764908)

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions GitHub Actions
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed for 'forest-client-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Frontend unit Test Coverage

Coverage after merging feat/FSADT1-1058 into main will be
55.92%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue48.39%50%0%68.42%108, 36, 39–40, 44, 52–53, 62
   directivesMap.ts100%100%100%100%
src/components
   DataFetcher.vue85%60%83.33%95.83%33–35, 50, 55
   MainHeaderComponent.vue79.69%76.56%58.33%88.46%100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
src/components/forms
   AutoCompleteInputComponent.vue75.37%58.14%80.95%84.29%111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
   DropdownInputComponent.vue90.10%87.10%83.33%94.23%111, 136, 67, 81, 81, 81–82
   MultiselectInputComponent.vue92.55%91.67%85.71%95.92%100, 109, 80, 89
   RadioInputComponent.vue87.50%85.71%75%93.33%39, 44, 80, 89
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue86.49%77.27%84.62%92.31%122, 130, 148, 55, 84, 89–90, 98
src/components/forms/DateInputComponent
   DateInputPart.vue91.30%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue81.32%75.28%75%86.18%137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 450, 460, 467, 473, 479
src/components/grouping
   AddressGroupComponent.vue1.22%0%0%2.73%104–105, 107, 107, 107, 111–112, 114–115, 115, 115, 115, 117, 124, 131, 140–141, 141, 141, 141, 143, 145, 147, 151, 153–154, 154, 154–155, 155, 155, 155, 157, 159, 161, 164, 168–169, 169, 169, 169, 171, 173, 175, 179–180, 180, 180, 183, 185–186, 186–187, 187, 189, 19, 192, 194–196, 196, 196, 196, 196–198, 206, 208–209, 212, 214, 219–220, 220, 220–225, 225, 225–227, 230, 234–235, 235, 235–236, 248, 248, 248, 255, 255, 255–256, 256, 256–257, 257, 261, 261, 261, 273, 273, 273–274, 274, 28, 280, 280, 280, 282, 282, 282–283, 283, 283, 285, 285, 293, 293, 293, 301, 301, 301–302, 302, 302, 306, 306, 306, 323, 323, 323–324, 324, 324, 338, 338, 338, 34, 340, 340, 340, 35, 351, 351, 351, 354, 354, 354–355, 355, 355, 359, 359, 361, 361, 361, 37, 40, 42, 42, 42, 46, 46, 46, 49–51, 53–54, 57, 61–63, 66–68, 72, 76, 76, 76, 76, 76, 76–77, 82, 84, 87–88, 88, 88, 88, 88–89, 92, 95
   ContactGroupComponent.vue69.29%84.31%46.67%67.80%103, 103, 103–104, 148, 157, 164, 173, 180, 188, 197, 205, 219, 225, 230, 236, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91
   ErrorNotificationGroupingComponent.vue77.14%64.52%66.67%90.91%110, 117, 117, 117, 121, 129, 129, 138, 150, 58, 63, 81, 90, 98
src/composables
   useFetch.ts90.77%73.68%100%97.56%117, 121, 130, 17, 51, 88
   useFocus.ts25.93%6.67%30%34.48%28, 28, 28–30, 30, 30–32, 34, 44, 49–50, 50, 50, 53, 53, 53, 55–57, 63, 63, 63, 66–67, 70, 85, 85, 85, 92, 95, 98
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/helpers
   CustomDirectives.ts21.43%13.04%50%22.22%10, 17–18, 18, 18–19, 19, 19–21, 21, 21–22, 24, 27, 27, 27–28, 35–36, 36, 36–37, 43–45, 45, 45–48, 5, 5–7, 7, 7–8, 8, 8–9
   DataConversors.ts75.61%79.17%50%73.33%33, 38, 38, 38, 38, 38–39, 4, 41
   ForestClientUserSession.ts22.73%8%27.27%28.85%

@github-actions GitHub Actions
Copy link
Contributor

Frontend component Test Coverage

Coverage after merging feat/FSADT1-1058 into main will be
93.05%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue100%100%100%100%
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue100%100%100%100%
   UserProfileComponent.vue100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue92.19%89.19%85.71%95.71%179, 208, 41, 47, 68, 81, 83
   DropdownInputComponent.vue91.67%92.31%83.33%94.23%111, 136, 81, 81–82
   MultiselectInputComponent.vue90.11%80.95%85.71%95.92%100, 109, 122, 41, 47, 89
   RadioInputComponent.vue100%100%100%100%
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue90.14%84.21%84.62%94.87%122, 130, 148, 55, 98
src/components/forms/DateInputComponent
   DateInputPart.vue100%100%100%100%
   common.ts100%100%100%100%
   index.vue100%100%100%100%
src/components/grouping
   AddressGroupComponent.vue89.67%89.89%90.70%89.09%115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 261, 306, 361
   ContactGroupComponent.vue91.24%93.75%90%89.83%103, 103–104, 219, 225, 247, 42, 84, 91
   ErrorNotificationGroupingComponent.vue100%100%100%100%
src/composables
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue100%100%100%100%
   FormBCSCPage.vue100%100%100%100%
   FormBCeIDPage.vue100%100%100%100%
   FormSubmittedPage.vue100%100%100%100%
   LandingPage.vue100%100%100%100%
   NotFoundPage.vue100%100%100%100%
   SubmissionListPage.vue100%100%100%100%
   SubmissionReviewPage.vue100%100%100%100%
   UserLoadingPage.vue100%100%100%100%
src/pages/bceidform
   AddressWizardStep.vue100%100%100%100%
   BusinessInformationWizardStep.vue100%100%100%100%
   ContactWizardStep.vue100%100%100%100%
   ReviewWizardStep.vue100%100%100%100%
src/services
   ForestClientService.ts100%100%100%100%

@github-actions GitHub Actions
Copy link
Contributor

Frontend e2e Test Coverage

Coverage after merging feat/FSADT1-1058 into main will be
72.83%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue83.87%75%50%100%62
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue47.58%50%8.33%53.85%100, 107, 122, 134, 141, 150, 173, 173–174, 174–175, 175–176, 176, 185, 185, 185, 197, 197, 197, 201, 217, 217, 217, 230, 249, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
   UserProfileComponent.vue30%0%0%42.86%11–12, 15, 17, 17, 17, 17, 19, 21, 23, 4
src/components/forms
   AutoCompleteInputComponent.vue92.97%91.89%85.71%95.71%179, 208, 47, 68, 81, 83
   DropdownInputComponent.vue96.88%96.15%94.44%98.08%111, 136
   MultiselectInputComponent.vue90.11%80.95%85.71%95.92%100, 109, 122, 41, 47, 89
   RadioInputComponent.vue88.89%75%83.33%96.67%39, 49, 80, 91
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue92.96%84.21%92.31%97.44%122, 130, 148, 55
src/components/forms/DateInputComponent
   DateInputPart.vue91.30%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue83.86%74.29%93.75%86.18%108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 467, 473, 479
src/components/grouping
   AddressGroupComponent.vue89.67%89.89%90.70%89.09%115, 131, 141, 147, 154–155, 155, 155, 155, 157, 159, 161, 169, 175, 186, 208–209, 225, 261, 306, 361
   ContactGroupComponent.vue98.54%100%100%96.61%84, 91
   ErrorNotificationGroupingComponent.vue40.91%14.81%66.67%57.58%110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 163, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 98, 98
src/composables
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue25%100%100%25%11–12, 2
   FormBCSCPage.vue83.41%66.67%71.88%91.97%120–121, 134, 204, 265, 267, 276, 291–293, 316, 316, 316, 318–319, 324, 365, 456, 478, 49–51, 513, 513, 513, 62, 79
   FormBCeIDPage.vue55.93%49.37%33.33%66.13%110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 279, 279–284, 298, 298–299, 304, 304–305, 305–306, 306, 311, 317–318, 320, 320–322, 327–328, 337, 340–344, 354, 354, 356–358, 429, 450, 450, 450, 467, 467, 467, 476, 515, 518, 518, 518, 537, 68–70, 89, 93–94, 96, 99
   FormSubmittedPage.vue61.11%25%0%83.33%12, 30, 32, 32, 32
   LandingPage.vue75%42.86%100%92.31%18, 18–19, 48, 58
   SubmissionListPage.vue8.05%0%0%12.73%103–105, 137, 153, 153, 178, 178, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
   SubmissionReviewPage.vue19.92%0%0%40.17%101, 103–105, 114, 114–115, 115, 120–121, 121–124, 128, 128, 142, 148–151, 151, 151–152, 154, 157, 160–161, 161–163, 166–167, 167–168, 170–171, 171–172, 175–176, 176–177, 177, 177–178, 181–182, 182, 182, 182, 182, 184, 186, 188, 190, 216, 216, 221, 221, 233, 233, 233, 233, 245, 245, 245, 245, 245, 268, 268, 268, 268, 268, 277, 277, 286, 32, 35–36, 384, 384, 39, 418, 418, 454, 454, 454–455, 455, 455, 459, 459, 459, 459–460,

@paulushcgcj paulushcgcj merged commit 62e3a59 into main Dec 14, 2023
17 checks passed
@paulushcgcj paulushcgcj deleted the feat/FSADT1-1058 branch December 14, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulushcgcj paulushcgcj paulushcgcj approved these changes

@mamartinezmejia mamartinezmejia Awaiting requested review from mamartinezmejia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fterra-encora @paulushcgcj