-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FSADT1-936): fixing CHES on non-dev env #683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulushcgcj
requested review from
DerekRoberts and
mamartinezmejia
as code owners
December 19, 2023 16:38
|
mamartinezmejia
approved these changes
Dec 19, 2023
|
paulushcgcj
added a commit
that referenced
this pull request
Dec 19, 2023
* fix: changing submission list limit added it as parameter * chore: removing swagger from legacy * fix(FSADT1-936): fixing non-dev ches issues * chore: removing swagger * fix(FSADT1-936): fixing ches params * fix(FSADT1-639): fixing email mechanism that is not triggered
12 tasks
mamartinezmejia
pushed a commit
that referenced
this pull request
Jan 4, 2024
) * fix(FSADT1-1042): filtering parties when not a person This is to remove the non-person parties associated to an entry that comes from BC Registry when the response is a sole proprietor. * feat(FSADT1-1042): updating 100% match for non individuals * fix(FSADT1-1052): updating list of contact type * fix(FSADT1-1042): adding error message for non person SP * fix: fixing matching message * fix: adding frontend validation to RSP non person * feat(FSADT1-1043): adding individual search adding search for individuals to be done during submission * fix(FSADT1-1049): replacing repository with webclient moving legacy related code into legacy only and making web requests instead * fix(FSADT1-1049): updating sole proprietor and test with webclient * fix(FSADT1-1049): updating incorporation and test with webclient * fix(FSADT1-1049): updating individual and test with webclient * fix(FSADT1-1049): updating legal name and test with webclient * fix(FSADT1-1049): adapting code to the lack of entity Adapted the code due to the removal of forest client entity * feat: adding mapstruct for conversion * feat: moving data from processor * feat: moving processing of legacy data from processor * chore: removing useless util * feat: adding mapper code for dto to entity conversion * chore: bringing constants * chore: temporary persisting processor code changes * fix: fixing test case * fix(FSADT1-936): fixing CHES on non-dev env (#683) * fix: changing submission list limit added it as parameter * chore: removing swagger from legacy * fix(FSADT1-936): fixing non-dev ches issues * chore: removing swagger * fix(FSADT1-936): fixing ches params * fix(FSADT1-639): fixing email mechanism that is not triggered * fix(FSADT1-1037): adding client contact creation * fix(FSADT1-1037): adding client dba creation * fix(FSADT1-1037): adding client creation * fix(FSADT1-1037): adding client doing business as creation * fix(FSADT1-1041): removing oracle entity data * fix(FSADT1-1041): adding legacy service and dtos - adding legacy service to serve as an interface for the legacy service - adding some of the DTOs that will be exchanged with the legacy service * fix(FSADT1-1041): switching repositories for the legacy - switched all repository and entity usage for the dtos and legacy service * fix(FSADT1-1044): updating doing business as matcher * chore: removed unused code * chore: moved packages * chore: fixing packages and test * ci: updating openshift configuration * fix: fixing local login issues - added a flag to control local samesite flag that prevents login * chore: removing oracle config from file * fix: fixing dba data * fix: fixing dba data * fix: fixing post submissions * fix(FSADT1-1037): fixing db dependencies * fix(FSADT1-1052): hiding unwanted user type * fix(FSADT1-1029): adding validation to prevent single word * chore: moving packages * fix(FSADT1-1039): adding contact matcher * fix(FSADT1-1039): adding contact matcher * fix(FSADT1-1039): adding contact search test * fix(FSADT1-1042): fixing tests * fix(FSADT1-1039): fixing contact test * chore: reverting testcontainer due to junit conflict * fix(FSADT1-1039): updating page to reflect new matchers * chore: updating workspace * fix(FSADT1-1059): off-ramping unsupported client types * chore: adding a clean and run coverage command * test: updating tests * test: adding test assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing CHES issues with non-dev environment while fixing inconsistencies with processor data marking
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow