Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FSADT1-936): fixing CHES on non-dev env #683

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Dec 18, 2023

Description

Fixing CHES issues with non-dev environment while fixing inconsistencies with processor data marking

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • No new tests are required

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added the fix label Dec 18, 2023
Copy link
Contributor

github-actions bot commented Dec 18, 2023

Current changelog

Bug Fixes

  • [FSADT1-1058] BCSC form breakpoints (#684) (b6a47b7)
  • changing submission list limit (6b624bf)
  • FSADT1-639: fixing email mechanism that is not triggered (5070c46)
  • FSADT1-936: fixing ches params (1f1efb0)
  • FSADT1-936: fixing non-dev ches issues (1f3bafb)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Dec 19, 2023
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 2727de2 into main Dec 19, 2023
16 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-936 branch December 19, 2023 17:24
paulushcgcj added a commit that referenced this pull request Dec 19, 2023
* fix: changing submission list limit

added it as parameter

* chore: removing swagger from legacy

* fix(FSADT1-936): fixing non-dev ches issues

* chore: removing swagger

* fix(FSADT1-936): fixing ches params

* fix(FSADT1-639): fixing email mechanism that is not triggered
mamartinezmejia pushed a commit that referenced this pull request Jan 4, 2024
)

* fix(FSADT1-1042): filtering parties when not a person

This is to remove the non-person parties associated to an entry that comes from BC Registry when the response is a sole proprietor.

* feat(FSADT1-1042): updating 100% match for non individuals

* fix(FSADT1-1052): updating list of contact type

* fix(FSADT1-1042): adding error message for non person SP

* fix: fixing matching message

* fix: adding frontend validation to RSP non person

* feat(FSADT1-1043): adding individual search

adding search for individuals to be done during submission

* fix(FSADT1-1049): replacing repository with webclient

moving legacy related code into legacy only and making web requests instead

* fix(FSADT1-1049): updating sole proprietor and test with webclient

* fix(FSADT1-1049): updating incorporation and test with webclient

* fix(FSADT1-1049): updating individual and test with webclient

* fix(FSADT1-1049): updating legal name and test with webclient

* fix(FSADT1-1049): adapting code to the lack of entity

Adapted the code due to the removal of forest client entity

* feat: adding mapstruct for conversion

* feat: moving data from processor

* feat: moving processing of legacy data from processor

* chore: removing useless util

* feat: adding mapper code for dto to entity conversion

* chore: bringing constants

* chore: temporary persisting processor code changes

* fix: fixing test case

* fix(FSADT1-936): fixing CHES on non-dev env (#683)

* fix: changing submission list limit

added it as parameter

* chore: removing swagger from legacy

* fix(FSADT1-936): fixing non-dev ches issues

* chore: removing swagger

* fix(FSADT1-936): fixing ches params

* fix(FSADT1-639): fixing email mechanism that is not triggered

* fix(FSADT1-1037): adding client contact creation

* fix(FSADT1-1037): adding client dba creation

* fix(FSADT1-1037): adding client creation

* fix(FSADT1-1037): adding client doing business as creation

* fix(FSADT1-1041): removing oracle entity data

* fix(FSADT1-1041): adding legacy service and dtos

- adding legacy service to serve as an interface for the legacy service
- adding some of the DTOs that will be exchanged with the legacy service

* fix(FSADT1-1041): switching repositories for the legacy

- switched all repository and entity usage for the dtos and legacy service

* fix(FSADT1-1044): updating doing business as matcher

* chore: removed unused code

* chore: moved packages

* chore: fixing packages and test

* ci: updating openshift configuration

* fix: fixing local login issues

- added a flag to control local samesite flag that prevents login

* chore: removing oracle config from file

* fix: fixing dba data

* fix: fixing dba data

* fix: fixing post submissions

* fix(FSADT1-1037): fixing db dependencies

* fix(FSADT1-1052): hiding unwanted user type

* fix(FSADT1-1029): adding validation to prevent single word

* chore: moving packages

* fix(FSADT1-1039): adding contact matcher

* fix(FSADT1-1039): adding contact matcher

* fix(FSADT1-1039): adding contact search test

* fix(FSADT1-1042): fixing tests

* fix(FSADT1-1039): fixing contact test

* chore: reverting testcontainer  due to junit conflict

* fix(FSADT1-1039): updating page to reflect new matchers

* chore: updating workspace

* fix(FSADT1-1059): off-ramping unsupported client types

* chore: adding a clean and run coverage command

* test: updating tests

* test: adding test assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants