Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSADT1-1040] Apply HTML heading tags to heading styles for Accessibility #709

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Jan 2, 2024

Description

Replaces tags with heading styles with a heading tag ( such h1, h2, h3, etc), following the definitions in the description of the ticket.
Please see also the comment in the ticket regarding fluid-heading styles.

Fixes FSADT1-1040

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed for 'forest-client-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Frontend unit Test Coverage

Coverage after merging feat/FSADT1-1040 into main will be
57.43%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue48.39%50%0%68.42%108, 36, 39–40, 44, 52–53, 62
   directivesMap.ts100%100%100%100%
src/components
   DataFetcher.vue85%60%83.33%95.83%33–35, 50, 55
   MainHeaderComponent.vue79.69%76.56%58.33%88.46%100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
src/components/forms
   AutoCompleteInputComponent.vue75.37%58.14%80.95%84.29%111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
   DropdownInputComponent.vue90.10%87.10%83.33%94.23%111, 136, 67, 81, 81, 81–82
   MultiselectInputComponent.vue92.55%91.67%85.71%95.92%100, 109, 80, 89
   RadioInputComponent.vue87.50%85.71%75%93.33%39, 44, 80, 89
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue86.49%77.27%84.62%92.31%105, 129, 137, 156, 62, 91, 96–97
src/components/forms/DateInputComponent
   DateInputPart.vue91.30%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue81.32%75.28%75%86.18%137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 450, 460, 467, 473, 479
src/components/grouping
   AddressGroupComponent.vue1.19%0%0%2.63%105–106, 108, 108, 108, 112–113, 115–116, 116, 116, 116, 118, 125, 132, 141–142, 142, 142, 142, 144, 146, 148, 152, 154–155, 155, 155–156, 156, 156, 156, 158, 160, 162, 165, 169–170, 170, 170, 172, 174, 178–179, 179, 179, 179, 181, 183, 185, 189–190, 190, 190, 193, 195–196, 196–197, 197, 199, 20, 202, 204–206, 206, 206, 206, 206–208, 216, 218–219, 222, 224, 229–230, 230, 230–235, 235, 235–237, 240, 244–245, 245, 245–246, 258, 258, 258, 265, 265, 265–266, 266, 266–267, 267, 271, 271, 271, 283, 283, 283–284, 284, 29, 290, 290, 290, 292, 292, 292–293, 293, 293, 295, 295, 303, 303, 303, 311, 311, 311–312, 312, 312, 316, 316, 316, 333, 333, 333–334, 334, 334, 348, 348, 348, 35, 350, 350, 350, 36, 362, 362, 362, 365, 365, 365–366, 366, 366, 370, 370, 372, 372, 372, 38, 41, 43, 43, 43, 47, 47, 47, 50–52, 54–55, 58, 62–64, 67–69, 73, 77, 77, 77, 77, 77, 77–78, 83, 85, 88–89, 89, 89, 89, 89–90, 93, 96
   ContactGroupComponent.vue68.35%85.45%42.42%67.14%103, 103, 103–104, 114–115, 138, 163, 172, 179, 188, 195, 203, 213, 221, 235, 241, 246, 252, 276, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91
   ErrorNotificationGroupingComponent.vue77.14%64.52%66.67%90.91%110, 117, 117, 117, 121, 129, 129, 138, 150, 58, 63, 81, 90, 98
src/composables
   useElementVisibility.ts96.55%87.50%100%100%6
   useFetch.ts90.77%73.68%100%97.56%117, 121, 130, 17, 51, 88
   useFocus.ts37.04%19.23%50%44.19%114, 120, 120, 120, 120, 120–121, 124, 128–130, 130, 130–131, 133, 142, 145, 148, 34, 36–38, 50, 55, 57, 60, 63, 63, 63, 65–67, 67, 67, 69, 71, 77, 77, 77, 80–81, 84, 99, 99, 99
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/helpers
   CustomDirectives.ts92.86%82.61%100%100%19, 36, 43, 45
   DataConversors.ts75.61%79.17%50%73.33%33, 38, 38, 38, 38, 38–39, 4, 41
   

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Frontend component Test Coverage

Coverage after merging feat/FSADT1-1040 into main will be
89.10%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue100%100%100%100%
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue100%100%100%100%
   UserProfileComponent.vue100%100%100%100%
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue92.19%89.19%85.71%95.71%179, 208, 41, 47, 68, 81, 83
   DropdownInputComponent.vue91.67%92.31%83.33%94.23%111, 136, 81, 81–82
   MultiselectInputComponent.vue92.31%90.48%85.71%95.92%100, 109, 47, 89
   RadioInputComponent.vue100%100%100%100%
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue90.14%84.21%84.62%94.87%105, 129, 137, 156, 62
src/components/forms/DateInputComponent
   DateInputPart.vue100%100%100%100%
   common.ts100%100%100%100%
   index.vue100%100%100%100%
src/components/grouping
   AddressGroupComponent.vue89.96%90.11%90.91%89.47%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 271, 316, 372
   ContactGroupComponent.vue91.61%96.15%87.88%90%103, 103–104, 235, 241, 263, 276, 84, 91
   ErrorNotificationGroupingComponent.vue100%100%100%100%
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue100%100%100%100%
   FormBCSCPage.vue100%100%100%100%
   FormBCeIDPage.vue100%100%100%100%
   FormSubmittedPage.vue100%100%100%100%
   LandingPage.vue100%100%100%100%
   NotFoundPage.vue100%100%100%100%
   SubmissionListPage.vue100%100%100%100%
   SubmissionReviewPage.vue100%100%100%100%
   UserLoadingPage.vue100%100%100%100%
src/pages/bceidform
   AddressWizardStep.vue100%100%100%100%
   BusinessInformationWizardStep.vue100%100%100%100%
   ContactWizardStep.vue59.05%65.22%47.83%61.02%118, 118, 118, 123, 143, 150, 171, 173, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 72–73, 76, 76–78, 80, 84–87
   ReviewWizardStep.vue100%100%100%100%
src/services
   ForestClientService.ts100%100%100%100%

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Frontend e2e Test Coverage

Coverage after merging feat/FSADT1-1040 into main will be
75.51%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue83.87%75%50%100%62
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue97.14%80%100%100%33
   MainHeaderComponent.vue47.58%50%8.33%53.85%100, 107, 122, 134, 141, 150, 173, 173–174, 174–175, 175–176, 176, 185, 185, 185, 197, 197, 197, 201, 217, 217, 217, 230, 249, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
   UserProfileComponent.vue30%0%0%42.86%11–12, 15, 17, 17, 17, 17, 19, 21, 23, 4
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue92.97%91.89%85.71%95.71%179, 208, 47, 68, 81, 83
   DropdownInputComponent.vue96.88%96.15%94.44%98.08%111, 136
   MultiselectInputComponent.vue92.31%90.48%85.71%95.92%100, 109, 47, 89
   RadioInputComponent.vue88.89%75%83.33%96.67%39, 49, 80, 91
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue92.96%84.21%92.31%97.44%129, 137, 156, 62
src/components/forms/DateInputComponent
   DateInputPart.vue91.30%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue83.86%74.29%93.75%86.18%108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 467, 473, 479
src/components/grouping
   AddressGroupComponent.vue89.96%90.11%90.91%89.47%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 271, 316, 372
   ContactGroupComponent.vue97.42%100%96.97%95.71%276, 84, 91
   ErrorNotificationGroupingComponent.vue40.91%14.81%66.67%57.58%110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 163, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 98, 98
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue25%100%100%25%11–12, 2
   FormBCSCPage.vue82.25%64.91%71.88%91.55%121–122, 135, 209, 270, 272, 281, 296–298, 306, 311, 323, 323, 323, 325–326, 331, 377, 463, 470, 477, 498, 50, 508, 51–52, 544, 544, 544, 63, 80
   FormBCeIDPage.vue56.33%48.78%33.33%66.92%110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 270, 276, 281, 281–286, 300, 300–301, 306, 306–307, 307–308, 308, 313, 319–320, 322, 322–324, 329–330, 339, 342–346, 356, 356, 358–360, 445, 467, 467, 467, 487, 487, 487, 496, 532, 535, 538, 538, 538, 557, 68–70, 89, 93–94, 96, 99
   FormSubmittedPage.vue61.11%25%0%83.33%12, 30, 32, 32, 32
   LandingPage.vue75%42.86%100%92.31%18, 18–19, 48, 58
   SubmissionListPage.vue8.05%0%0%12.73%103–105, 137, 153, 153, 178, 178, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
   SubmissionReviewPage.vue19.92%0%0%40.17%101, 103–105, 114, 114–115, 115, 120–121, 121–124, 128, 128, 142, 148–151, 151, 151–152, 154, 157, 160–161, 161–163, 166–167, 167–168, 170–171, 171–172, 175–176, 176–177, 177, 177–178, 181–182, 182, 182, 182, 182, 184, 186, 188, 190, 216, 216, 221, 221, 233, 233, 233, 233, 245, 245, 245, 245, 245, 268, 268, 268, 268, 268, 277, 277, 286, 32, 35–36, 384, 384, 39,

@paulushcgcj paulushcgcj merged commit 168b37f into main Jan 3, 2024
17 checks passed
@paulushcgcj paulushcgcj deleted the feat/FSADT1-1040 branch January 3, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants