[FSADT1-971 v2] BCSC - Confirmation message for deleting a contact

[fterra-encora]

Description

Fixes the confirmation message for deleting a contact on BCSC form.

Fixes FSADT1-971 (v2 - 15/Dec/23) - This is a different request since the ticket was updated to handle the BCSC form after #652.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• New unit tests
• New integrated tests
• New component tests
• New end-to-end tests
• New user flow tests
• No new tests are required
• Manual tests (description below)

Checklist

• I have read the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have already been accepted and merged

Further comments

[github-actions]

Current changelog

Bug Fixes

• fix confirmation message (967a305)

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[sonarcloud]

Quality Gate passed for 'forest-client-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Frontend unit Test Coverage

Coverage after merging fix/FSADT1-971 into main will be

57.29%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	48.39%	50%	0%	68.42%	108, 36, 39–40, 44, 52–53, 62
directivesMap.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	85%	60%	83.33%	95.83%	33–35, 50, 55
MainHeaderComponent.vue	79.69%	76.56%	58.33%	88.46%	100, 107, 111, 122, 124, 134, 136, 147, 173, 176, 185, 201, 217, 217, 217, 230, 249, 41, 50–51, 55
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
src/components/forms
AutoCompleteInputComponent.vue	75.37%	58.14%	80.95%	84.29%	111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
DropdownInputComponent.vue	90.10%	87.10%	83.33%	94.23%	111, 136, 67, 81, 81, 81–82
MultiselectInputComponent.vue	92.55%	91.67%	85.71%	95.92%	100, 109, 80, 89
RadioInputComponent.vue	87.50%	85.71%	75%	93.33%	39, 44, 80, 89
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	86.49%	77.27%	84.62%	92.31%	105, 129, 137, 156, 62, 91, 96–97
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	81.32%	75.28%	75%	86.18%	137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 450, 460, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	1.21%	0%	0%	2.70%	105–106, 108, 108, 108, 112–113, 115–116, 116, 116, 116, 118, 125, 132, 141–142, 142, 142, 142, 144, 146, 148, 152, 154–155, 155, 155–156, 156, 156, 156, 158, 160, 162, 165, 169–170, 170, 170, 172, 174, 178–179, 179, 179, 179, 181, 183, 185, 189–190, 190, 190, 193, 195–196, 196–197, 197, 199, 20, 202, 204–206, 206, 206, 206, 206–208, 216, 218–219, 222, 224, 229–230, 230, 230–235, 235, 235–237, 240, 253, 253, 253, 260, 260, 260–261, 261, 261–262, 262, 266, 266, 266, 278, 278, 278–279, 279, 285, 285, 285, 287, 287, 287–288, 288, 288, 29, 290, 290, 298, 298, 298, 306, 306, 306–307, 307, 307, 311, 311, 311, 328, 328, 328–329, 329, 329, 343, 343, 343, 345, 345, 345, 35, 357, 357, 357, 36, 360, 360, 360–361, 361, 361, 365, 365, 367, 367, 367, 38, 41, 43, 43, 43, 47, 47, 47, 50–52, 54–55, 58, 62–64, 67–69, 73, 77, 77, 77, 77, 77, 77–78, 83, 85, 88–89, 89, 89, 89, 89–90, 93, 96
ContactGroupComponent.vue	66.89%	84.91%	40.63%	65.15%	106–107, 130, 155, 164, 171, 180, 187, 195, 205, 213, 227, 233, 238, 244, 268, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91, 95, 95, 95–96
ErrorNotificationGroupingComponent.vue	77.14%	64.52%	66.67%	90.91%	110, 117, 117, 117, 121, 129, 129, 138, 150, 58, 63, 81, 90, 98
src/composables
useElementVisibility.ts	96.55%	87.50%	100%	100%	6
useFetch.ts	87.69%	68.42%	100%	95.12%	117, 121, 130, 17, 51, 62, 66, 88
useFocus.ts	37.04%	19.23%	50%	44.19%	114, 120, 120, 120, 120, 120–121, 124, 128–130, 130, 130–131, 133, 142, 145, 148, 34, 36–38, 50, 55, 57, 60, 63, 63, 63, 65–67, 67, 67, 69, 71, 77, 77, 77, 80–81, 84, 99, 99, 99
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	92.86%	82.61%	100%	100%	19, 36, 43, 45
DataConversors.ts	75.61%	79.17%	50%	73.33%	33, 38, 38, 38, 38, 38–39, 4, 41
ForestClientUserSession.ts	22.73%	8%	27.27%	28.85%

[github-actions]

Frontend component Test Coverage

Coverage after merging fix/FSADT1-971 into main will be

88.94%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	100%	100%	100%	100%
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	100%	100%	100%	100%
UserProfileComponent.vue	100%	100%	100%	100%
types.ts	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	92.19%	89.19%	85.71%	95.71%	179, 208, 41, 47, 68, 81, 83
DropdownInputComponent.vue	91.67%	92.31%	83.33%	94.23%	111, 136, 81, 81–82
MultiselectInputComponent.vue	92.31%	90.48%	85.71%	95.92%	100, 109, 47, 89
RadioInputComponent.vue	100%	100%	100%	100%
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	90.14%	84.21%	84.62%	94.87%	105, 129, 137, 156, 62
src/components/forms/DateInputComponent
DateInputPart.vue	100%	100%	100%	100%
common.ts	100%	100%	100%	100%
index.vue	100%	100%	100%	100%
src/components/grouping
AddressGroupComponent.vue	89.71%	89.89%	90.70%	89.19%	116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
ContactGroupComponent.vue	91.22%	96%	87.50%	89.39%	227, 233, 255, 268, 84, 91, 95, 95–96
ErrorNotificationGroupingComponent.vue	100%	100%	100%	100%
src/composables
useElementVisibility.ts	100%	100%	100%	100%
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	100%	100%	100%	100%
FormBCSCPage.vue	100%	100%	100%	100%
FormBCeIDPage.vue	100%	100%	100%	100%
FormSubmittedPage.vue	100%	100%	100%	100%
LandingPage.vue	100%	100%	100%	100%
NotFoundPage.vue	100%	100%	100%	100%
SubmissionListPage.vue	100%	100%	100%	100%
SubmissionReviewPage.vue	100%	100%	100%	100%
UserLoadingPage.vue	100%	100%	100%	100%
src/pages/bceidform
AddressWizardStep.vue	100%	100%	100%	100%
BusinessInformationWizardStep.vue	100%	100%	100%	100%
ContactWizardStep.vue	59.05%	65.22%	47.83%	61.02%	118, 118, 118, 123, 143, 150, 171, 173, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 72–73, 76, 76–78, 80, 84–87
ReviewWizardStep.vue	100%	100%	100%	100%
src/services
ForestClientService.ts	100%	100%	100%	100%

[github-actions]

Frontend e2e Test Coverage

Coverage after merging fix/FSADT1-971 into main will be

75.24%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	83.87%	75%	50%	100%	62
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	47.58%	50%	8.33%	53.85%	100, 107, 122, 134, 141, 150, 173, 173–174, 174–175, 175–176, 176, 185, 185, 185, 197, 197, 197, 201, 217, 217, 217, 230, 249, 41, 41–42, 50, 50, 50, 50–51, 53–55, 55–56, 56, 56–57, 59, 66–67, 70–72, 81, 87, 87, 87–88, 90
UserProfileComponent.vue	30%	0%	0%	42.86%	11–12, 15, 17, 17, 17, 17, 19, 21, 23, 4
types.ts	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	92.97%	91.89%	85.71%	95.71%	179, 208, 47, 68, 81, 83
DropdownInputComponent.vue	96.88%	96.15%	94.44%	98.08%	111, 136
MultiselectInputComponent.vue	92.31%	90.48%	85.71%	95.92%	100, 109, 47, 89
RadioInputComponent.vue	88.89%	75%	83.33%	96.67%	39, 49, 80, 91
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	92.96%	84.21%	92.31%	97.44%	129, 137, 156, 62
src/components/forms/DateInputComponent
DateInputPart.vue	91.30%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	83.86%	74.29%	93.75%	86.18%	108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 467, 473, 479
src/components/grouping
AddressGroupComponent.vue	89.71%	89.89%	90.70%	89.19%	116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
ContactGroupComponent.vue	97.30%	100%	96.88%	95.45%	268, 84, 91
ErrorNotificationGroupingComponent.vue	40.91%	14.81%	66.67%	57.58%	110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 163, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 98, 98
src/composables
useElementVisibility.ts	100%	100%	100%	100%
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	25%	100%	100%	25%	11–12, 2
FormBCSCPage.vue	82.25%	64.91%	71.88%	91.55%	121–122, 135, 209, 270, 272, 281, 296–298, 306, 311, 323, 323, 323, 325–326, 331, 377, 463, 470, 477, 498, 50, 508, 51–52, 544, 544, 544, 63, 80
FormBCeIDPage.vue	56.33%	48.78%	33.33%	66.92%	110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 270, 276, 281, 281–286, 300, 300–301, 306, 306–307, 307–308, 308, 313, 319–320, 322, 322–324, 329–330, 339, 342–346, 356, 356, 358–360, 445, 467, 467, 467, 487, 487, 487, 496, 532, 535, 538, 538, 538, 557, 68–70, 89, 93–94, 96, 99
FormSubmittedPage.vue	61.11%	25%	0%	83.33%	12, 30, 32, 32, 32
LandingPage.vue	75%	42.86%	100%	92.31%	18, 18–19, 48, 58
SubmissionListPage.vue	8.05%	0%	0%	12.73%	103–105, 137, 153, 153, 178, 178, 23, 26–28, 31–34, 37–38, 41–42, 42–43, 46, 46, 46, 49–51, 54–55, 55, 55, 55, 55, 57, 59, 61, 63, 67–69, 69, 72–73, 75–76, 79–82, 82, 82–83, 85, 88, 91–92, 92–93, 96–97, 97, 97, 97–99
SubmissionReviewPage.vue	19.92%	0%	0%	40.17%	101, 103–105, 114, 114–115, 115, 120–121, 121–124, 128, 128, 142, 148–151, 151, 151–152, 154, 157, 160–161, 161–163, 166–167, 167–168, 170–171, 171–172, 175–176, 176–177, 177, 177–178, 181–182, 182, 182, 182, 182, 184, 186, 188, 190, 216, 216, 221, 221, 233, 233, 233, 233, 245, 245, 245, 245, 245, 268, 268, 268, 268, 268, 277, 277, 286, 32, 35–36, 384, 384, 39,