Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing some pending issues #718

Merged
merged 7 commits into from
Jan 8, 2024
Merged

fix: fixing some pending issues #718

merged 7 commits into from
Jan 8, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Jan 6, 2024

Description

Fixing some of the existing issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@github-actions github-actions bot added the fix label Jan 6, 2024
Copy link
Contributor

github-actions bot commented Jan 6, 2024

Current changelog

Bug Fixes

  • FSADT1-1052: fixing list of client types (42c954f)
  • FSADT1-1101|FSADT1-1103|FSADT1-1106: fixing review email (589765d)
  • FSADT1-1104: removing limit to active clients only (f9af157)
  • FSADT1-1106: adding environment and mail list (f8830fd)

- added a mail list as a parameter instead of hardcoded
- setting environment name on email subject when not in prod
@github-actions github-actions bot added fix and removed fix labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit d65d86c into main Jan 8, 2024
16 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1099 branch January 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants