[FSADT1-1102] Can not click button in Accept/Reject (using Edge)

[fterra-encora]

Description

Prevents the body of the modal from taking more space than it should by keeping its code simple, without having to set its height. This was possible by making the "Matching client number" field always take the amount of space it needs, even when it's not visible, by using visibility: hidden.

Fixes FSADT1-1102

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• New unit tests
• New integrated tests
• New component tests
• New end-to-end tests
• New user flow tests
• No new tests are required
• Manual tests (description below)

Checklist

• I have read the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have already been accepted and merged

Further comments

---

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Current changelog

Bug Fixes

• adjust approve/reject modals (ed907e3)
• apply css class defined on Figma (1fa77bf)
• remove remaining space in approve/reject modals (d50fbac)

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[github-actions]

Overall Project	NaN% NaN%	🍏

There is no coverage information present for the Files changed

[sonarcloud]

Quality Gate passed for 'forest-client-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Frontend unit Test Coverage

Coverage after merging fix/FSADT1-1102 into main will be

57.18%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	50%	50%	0%	70%	108, 36, 39–40, 44, 52–53, 61–62
directivesMap.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	85%	60%	83.33%	95.83%	33–35, 50, 55
MainHeaderComponent.vue	81.48%	78.57%	70%	87.27%	105, 112, 116, 127, 129, 139, 141, 152, 178, 181, 190, 206, 222, 222, 222, 235, 246, 257, 44, 53–54, 58
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
src/components/forms
AutoCompleteInputComponent.vue	75.56%	58.14%	80.95%	84.51%	111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
DropdownInputComponent.vue	90.20%	87.10%	83.33%	94.34%	111, 136, 67, 81, 81, 81–82
MultiselectInputComponent.vue	92.63%	91.67%	85.71%	96%	100, 109, 80, 89
RadioInputComponent.vue	87.72%	85.71%	75%	93.55%	39, 44, 80, 89
ReadOnlyComponent.vue	66.67%	100%	100%	66.67%	2
TextInputComponent.vue	85.71%	75%	84.62%	92.50%	1, 105, 123, 129, 137, 62, 91, 96–97
src/components/forms/DateInputComponent
DateInputPart.vue	91.67%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	81.16%	74.73%	75%	86.27%	1, 1, 137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 432, 450, 460, 467
src/components/grouping
AddressGroupComponent.vue	1.23%	0%	0%	2.68%	1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 105–106, 108, 108, 108, 112–113, 115–116, 116, 116, 116, 118, 125, 132, 141–142, 142, 142, 142, 144, 146, 148, 152, 154–155, 155, 155–156, 156, 156, 156, 158, 160, 162, 165, 169–170, 170, 170, 172, 174, 178–179, 179, 179, 179, 181, 183, 185, 189–190, 190, 190, 193, 195–196, 196–197, 197, 199, 20, 202, 204–206, 206, 206, 206, 206–208, 216, 218–219, 222, 224, 229–230, 230, 230–235, 235, 235–237, 240, 253, 260, 260, 260–261, 261, 261–262, 262, 266, 270, 278–279, 279, 285, 285, 285, 287, 287, 287–288, 288, 288, 29, 290, 290, 298, 306, 306, 306–307, 307, 307, 311, 328, 328, 328–329, 329, 329, 343, 343, 343, 345, 345, 345, 35, 357, 36, 360, 360, 360–361, 361, 361, 365, 365, 367, 367, 367, 38, 41, 43, 43, 43, 47, 47, 47, 50–52, 54–55, 58, 62–64, 67–69, 73, 77, 77, 77, 77, 77, 77–78, 83, 85, 88–89, 89, 89, 89, 89–90, 93, 96
ContactGroupComponent.vue	69.80%	85.45%	48.15%	65.67%	106–107, 130, 155, 164, 171, 180, 187, 195, 205, 213, 227, 233, 238, 244, 268, 42, 55–56, 83, 83, 83–84, 90, 90, 90–91, 95, 95, 95–96
ErrorNotificationGroupingComponent.vue	78.38%	66.67%	66.67%	91.43%	110, 117, 117, 117, 121, 129, 129, 138, 150, 58, 63, 81, 90, 98
src/composables
useElementVisibility.ts	96.55%	87.50%	100%	100%	6
useFetch.ts	90.77%	73.68%	100%	97.56%	117, 121, 130, 17, 51, 88
useFocus.ts	37.04%	19.23%	50%	44.19%	114, 120, 120, 120, 120, 120–121, 124, 128–130, 130, 130–131, 133, 142, 145, 148, 34, 36–38, 50, 55, 57, 60, 63, 63, 63, 65–67, 67, 67, 69, 71, 77, 77, 77, 80–81, 84, 99, 99, 99
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	92.86%	82.61%	100%	100%	19, 36, 43, 45
DataConversors.ts	75.61%	79.17%	50%	73.33%	33, 38, 38, 38, 38, 38–39, 4, 41

[github-actions]

Frontend component Test Coverage

Coverage after merging fix/FSADT1-1102 into main will be

65.62%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	100%	100%	100%	100%
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	100%	100%	100%	100%
UserProfileComponent.vue	100%	100%	100%	100%
types.ts	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	93.02%	91.89%	85.71%	95.77%	179, 208, 47, 68, 81, 83
DropdownInputComponent.vue	91.75%	92.31%	83.33%	94.34%	111, 136, 81, 81–82
MultiselectInputComponent.vue	92.39%	90.48%	85.71%	96%	100, 109, 47, 89
RadioInputComponent.vue	89.09%	75%	83.33%	96.77%	39, 49, 80, 91
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	89.19%	80.95%	84.62%	95%	1, 105, 123, 129, 137, 62
src/components/forms/DateInputComponent
DateInputPart.vue	12.50%	0%	0%	21.43%	16, 21, 23, 25, 27, 31, 37, 39, 46, 46, 50, 50, 57, 57, 57–58, 58, 58, 8
common.ts	100%	100%	100%	100%
index.vue	3.11%	0%	0%	5.23%	1, 1, 1, 1, 101, 101–103, 106, 106–108, 108, 108, 114, 114, 114, 114–115, 117, 120, 120, 122, 128, 128, 128, 128–129, 132, 135–137, 140, 146, 148–149, 149, 149, 152, 154–156, 158, 160–161, 161, 161, 161, 163–164, 164, 164, 164, 167, 169, 171–174, 177–182, 182, 182, 182–185, 185–186, 189, 193–194, 198–201, 203, 203–204, 207–208, 212–213, 213, 215, 215, 215–216, 218, 218–219, 222–223, 225, 228, 234, 240, 246, 269, 269, 269, 269–270, 272–273, 280, 280–281, 283–285, 296, 296, 296–297, 297, 297–298, 298, 298, 30, 300, 300–301, 304–307, 309, 311, 311–312, 312, 312, 312, 316, 319, 319–320, 322, 325–327, 329–333, 336–337, 340, 340–342, 344–345, 347–348, 350, 352, 352–353, 358, 363, 365, 371, 373–379, 379–381, 381–384, 384–385, 391–393, 395, 432, 432, 439, 439–440, 440, 440, 449, 449–450, 450, 450, 459, 459–460, 460, 460, 467, 467, 54, 76, 76, 76, 78, 80, 86, 92
src/components/grouping
AddressGroupComponent.vue	90.79%	89.89%	97.37%	89.29%	116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
ContactGroupComponent.vue	91.78%	96.15%	88.89%	89.55%	227, 233, 255, 268, 84, 91, 95, 95–96
ErrorNotificationGroupingComponent.vue	100%	100%	100%	100%
src/composables
useElementVisibility.ts	100%	100%	100%	100%
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	100%	100%	100%	100%
FormBCSCPage.vue	100%	100%	100%	100%
FormBCeIDPage.vue	100%	100%	100%	100%
FormSubmittedPage.vue	100%	100%	100%	100%
LandingPage.vue	100%	100%	100%	100%
NotFoundPage.vue	100%	100%	100%	100%
SubmissionListPage.vue	100%	100%	100%	100%
SubmissionReviewPage.vue	100%	100%	100%	100%
UserLoadingPage.vue	100%	100%	100%	100%
src/pages/bceidform
AddressWizardStep.vue	100%	100%	100%	100%
BusinessInformationWizardStep.vue	45.26%	46.24%	45.83%	44.35%	1, 1, 1, 1, 103–105, 107, 107, 107–108, 108, 108–109, 109, 109, 111, 111, 111, 111, 111, 111–113, 115–116, 125, 127, 127, 127, 127–128, 130, 132, 134, 137, 139, 141, 149, 155–157, 157–159, 161, 161–163, 165, 165–169, 172, 175, 177, 183, 183–185, 189, 192–193, 193–195, 197, 203–204, 206–208, 208, 208, 212–214, 223, 223, 223–224, 227, 230, 251, 258, 270, 278–279, 282, 288, 311, 321, 343, 358, 376, 380, 386, 386, 386, 400, 404, 404, 404–405, 405, 405, 49, 71, 75, 83, 83, 89
ContactWizardStep.vue	59.26%	64%	47.83%	61.67%	118, 118, 118, 123, 143, 150, 154, 171, 173, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 72–73, 76, 76–78, 80, 84–87
ReviewWizardStep.vue	100%	100%	100%	100%
src/services

[github-actions]

Frontend e2e Test Coverage

Coverage after merging fix/FSADT1-1102 into main will be

82.24%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
App.vue	85.29%	83.33%	50%	100%	62
CoreConstants.ts	100%	100%	100%	100%
directivesMap.ts	100%	100%	100%	100%
main.ts	100%	100%	100%	100%
routes.ts	100%	100%	100%	100%
shims-vue.d.ts	100%	100%	100%	100%
src/components
DataFetcher.vue	97.14%	80%	100%	100%	33
MainHeaderComponent.vue	64.89%	77.27%	10%	60%	139, 178–181, 190, 202, 202, 202, 222, 235, 246, 257, 44, 44–45, 53, 53, 53, 53–54, 56–58, 58–59, 59, 59–60, 62, 75, 84, 90, 90, 90–91, 93
UserProfileComponent.vue	80%	33.33%	100%	85.71%	17, 17, 19, 23
types.ts	100%	100%	100%	100%
src/components/forms
AutoCompleteInputComponent.vue	93.02%	91.89%	85.71%	95.77%	179, 208, 47, 68, 81, 83
DropdownInputComponent.vue	96.91%	96.15%	94.44%	98.11%	111, 136
MultiselectInputComponent.vue	92.39%	90.48%	85.71%	96%	100, 109, 47, 89
RadioInputComponent.vue	89.09%	75%	83.33%	96.77%	39, 49, 80, 91
ReadOnlyComponent.vue	100%	100%	100%	100%
TextInputComponent.vue	91.89%	80.95%	92.31%	97.50%	1, 123, 129, 137, 62
src/components/forms/DateInputComponent
DateInputPart.vue	91.67%	75%	100%	100%	46, 50
common.ts	100%	100%	100%	100%
index.vue	83.66%	73.61%	93.75%	86.27%	1, 1, 108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 432, 467
src/components/grouping
AddressGroupComponent.vue	90.79%	89.89%	97.37%	89.29%	116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311, 367
ContactGroupComponent.vue	97.26%	100%	96.30%	95.52%	268, 84, 91
ErrorNotificationGroupingComponent.vue	42.86%	17.24%	66.67%	60%	110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 150, 150, 163, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 95, 98, 98
src/composables
useElementVisibility.ts	100%	100%	100%	100%
useFetch.ts	100%	100%	100%	100%
useFocus.ts	100%	100%	100%	100%
useScreenSize.ts	100%	100%	100%	100%
useSvg.ts	100%	100%	100%	100%
src/dto
ApplyClientNumberDto.ts	100%	100%	100%	100%
CommonTypesDto.ts	100%	100%	100%	100%
src/helpers
CustomDirectives.ts	100%	100%	100%	100%
DataConversors.ts	100%	100%	100%	100%
ForestClientUserSession.ts	100%	100%	100%	100%
src/helpers/validators
BCeIDFormValidations.ts	100%	100%	100%	100%
GlobalValidators.ts	100%	100%	100%	100%
SubmissionValidators.ts	100%	100%	100%	100%
src/pages
ErrorPage.vue	25%	100%	100%	25%	11–12, 2
FormBCSCPage.vue	82.83%	66.10%	74.19%	91.61%	1, 121–122, 135, 209, 270, 272, 281, 296–298, 306, 311, 323, 323, 323, 325–326, 331, 377, 463, 470, 477, 50, 508, 51–52, 544, 544, 544, 63, 80
FormBCeIDPage.vue	57.87%	51.09%	36.67%	67.42%	1, 1, 1, 1, 1, 110–112, 118, 118–119, 124, 124, 124, 127–128, 133, 239, 241, 250, 260–261, 261, 261, 261, 261, 261–264, 270, 276, 281, 281–286, 300, 300–301, 306, 306–307, 307–308, 308, 313, 319–320, 322, 322–324, 329–331, 340, 343–347, 357, 357, 359–361, 446, 453, 468, 476, 488, 497, 536, 539, 539, 539, 558, 68–70, 89, 93–94, 96, 99
FormSubmittedPage.vue	61.11%	25%	0%	83.33%	12, 30, 32, 32, 32
LandingPage.vue	76.19%	42.86%	100%	92.86%	18, 18–19, 48, 58
SubmissionListPage.vue	93.26%	77.78%	100%	96.43%	153, 42–43, 46, 82, 85
SubmissionReviewPage.vue	75.86%	74.71%	65.12%	80.15%	100, 106–108, 117, 117–118, 118, 123–124, 124–127, 131, 131, 145, 170, 174, 179–180, 180, 180, 185, 191, 250, 447, 484, 488–489, 501, 522, 535, 553, 560, 577, 80–81, 83, 89–90, 90–91, 97, 97, 97, 97–98
UserLoadingPage.vue	14.29%	0%	100%	20%	12, 14, 14, 14–15, 17
src/pages/bceidform
AddressWizardStep.vue	50.94%	57.14%	39.13%	53.23%	107–111, 122, 122, 122, 125, 141, 145, 149, 163–165, 178, 37, 37–38, 38, 38, 40–42, 46, 46–50, 52, 52–53, 58, 76–79
BusinessInformationWizardStep.vue	77.16%	76.34%	87.50%	75.65%	1, 1, 103–104, 107, 111–113, 157, 157–159, 161, 161–163, 165, 165–169, 172, 193, 203–204, 206–208, 208, 208, 212–214, 223, 227, 230, 251, 258, 288, 311, 321, 343, 358, 376, 380, 49, 71, 75, 89
ContactWizardStep.vue	59.26%	64%	47.83%	61.67%	118, 118, 118, 123,