Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed small issue in global error msg #794

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

mamartinezmejia
Copy link
Collaborator

@mamartinezmejia mamartinezmejia commented Feb 8, 2024


Thanks for the PR!

Any successful deployments (not always required) will be available here

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Current changelog

Bug Fixes

  • associate incoming contact to the default address (#793) (a325e60)
  • Fixed small issue in global error msg (0aec29d)

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'forest-client-frontend'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Frontend unit Test Coverage

Coverage after merging fix/fe/fix-error-msg into main will be
56.53%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue50%50%0%70%108, 36, 39–40, 44, 52–53, 61–62
   directivesMap.ts100%100%100%100%
src/components
   DataFetcher.vue85%60%83.33%95.83%33–35, 50, 55
   MainHeaderComponent.vue81.48%78.57%70%87.27%105, 112, 116, 127, 129, 139, 141, 152, 178, 181, 190, 206, 222, 222, 222, 235, 246, 257, 44, 53–54, 58
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
src/components/forms
   AutoCompleteInputComponent.vue75.56%58.14%80.95%84.51%111–112, 128, 133–134, 179, 208, 47, 60, 62, 62, 62, 62, 62–64, 66, 66, 66–68, 78, 81, 81, 81, 81, 81, 83, 85
   DropdownInputComponent.vue89.62%90.91%78.95%92.59%136, 169, 67, 81, 81, 81–82
   MultiselectInputComponent.vue89.90%88.46%81.82%94.12%100, 109, 137, 41, 80, 89
   RadioInputComponent.vue87.72%85.71%75%93.55%39, 44, 80, 89
   ReadOnlyComponent.vue66.67%100%100%66.67%2
   TextInputComponent.vue85.71%75%84.62%92.50%1, 105, 123, 129, 137, 62, 91, 96–97
src/components/forms/DateInputComponent
   DateInputPart.vue91.67%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue81.16%74.73%75%86.27%1, 1, 137, 172–174, 182–185, 185, 185–186, 213, 215, 218–219, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 319–320, 330–333, 340, 352, 381, 384, 432, 450, 460, 467
src/components/grouping
   AddressGroupComponent.vue1.64%0%0%3.54%1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 105–106, 108, 108, 108, 112–113, 115–116, 116, 116, 116, 118, 125, 132, 141–142, 142, 142, 142, 144, 146, 148, 152, 154–155, 155, 155–156, 156, 156, 156, 158, 160, 162, 165, 169–170, 170, 170, 172, 174, 178–179, 179, 179, 179, 181, 183, 185, 189–190, 190, 190, 193, 195–196, 196–197, 197, 199, 20, 202, 204–206, 206, 206, 206, 206–208, 216, 218–219, 222, 224, 229–230, 230, 230–235, 235, 235–237, 240, 253, 260, 260, 260–261, 261, 261–262, 262, 266, 270, 278–279, 279, 285, 285, 285, 287, 287, 287–288, 288, 288, 29, 290, 290, 298, 306, 306, 306–307, 307, 307, 311, 328, 328, 328–329, 329, 329, 343, 343, 343, 345, 345, 345, 35, 357, 36, 360, 360, 360–361, 361, 361, 365, 365, 368, 368, 368, 38, 41, 43, 43, 43, 47, 47, 47, 50–52, 54–55, 58, 62–64, 67–69, 73, 77, 77, 77, 77, 77, 77–78, 83, 85, 88–89, 89, 89, 89, 89–90, 93, 96
   ContactGroupComponent.vue86.16%93.44%75.86%84.06%106–107, 130, 164, 180, 195, 213, 270, 42, 83–84, 90–91, 95–96
   ErrorNotificationGroupingComponent.vue76.32%62.86%66.67%91.43%110, 117, 117, 117, 121, 129, 129, 138, 147, 147, 153, 58, 63, 81, 90, 98
src/composables
   useElementVisibility.ts96.55%87.50%100%100%6
   useFetch.ts92.21%83.87%100%97.56%126, 130, 139, 18, 56, 93
   useFocus.ts50.62%38.46%58.33%55.81%120–121, 129–130, 130, 130–131, 133, 142, 145, 148, 34, 50, 55, 57, 60, 63, 63, 63, 65–67, 67, 67, 69, 71, 77, 77, 77, 80–81, 84, 99, 99, 99
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/helpers
   CustomDirectives.ts94.64%86.96%100%100%36, 43, 45
   DataConversors.ts75.61%79.17%50%73.33%33, 38, 38, 38, 38, 38–39, 4, 41
   ForestClientUserSession.ts22.22%7.41%27.27%28.85%111–115, 115, 115–116, 124–127, 13, 17–18, 22, 26, 26, 26–27, 30, 37–38, 38, 38–39, 42, 42, 42–4

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Frontend component Test Coverage

Coverage after merging fix/fe/fix-error-msg into main will be
78.56%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue100%100%100%100%
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue100%100%100%100%
   MainHeaderComponent.vue100%100%100%100%
   UserProfileComponent.vue100%100%100%100%
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue94.57%91.89%90.48%97.18%179, 208, 68, 81, 83
   DropdownInputComponent.vue98.02%96.43%94.74%100%111
   MultiselectInputComponent.vue82.29%78.26%72.73%88.24%100, 109, 122, 41, 47, 79–80, 80–82, 89
   RadioInputComponent.vue89.09%75%83.33%96.77%39, 49, 80, 91
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue94.59%90.48%92.31%97.50%105, 129, 137
src/components/forms/DateInputComponent
   DateInputPart.vue75%75%0%85.71%46, 50, 57–58
   common.ts100%100%100%100%
   index.vue35.41%33.33%21.88%39.22%1, 1, 101, 101–103, 106, 106–108, 108, 108, 114, 114, 114, 114–115, 117, 120, 120, 122, 128, 128, 128, 128–129, 132, 137, 149, 161, 161, 164, 164, 172–174, 178–182, 182, 182, 182–185, 185–186, 189, 194, 199–201, 203, 203–204, 207–208, 213, 213, 215, 215, 215–216, 218, 218–219, 222–223, 225, 269, 269, 269, 269–270, 272–273, 280, 280–281, 283–285, 296–298, 300–301, 305–307, 309, 311, 311–312, 312, 312, 312, 316, 319, 319–320, 322, 330–333, 340, 340–342, 344–345, 347–348, 350, 352, 352–353, 358, 374–379, 379–381, 381–384, 384–385, 432, 440, 450, 460, 467
src/components/grouping
   AddressGroupComponent.vue91.25%89.89%97.37%90.27%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311
   ContactGroupComponent.vue91.67%98.28%86.21%88.41%227, 229, 257, 270, 84, 91, 95, 95–96
   ErrorNotificationGroupingComponent.vue100%100%100%100%
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue100%100%100%100%
   FormBCSCPage.vue100%100%100%100%
   FormBCeIDPage.vue100%100%100%100%
   FormSubmittedPage.vue100%100%100%100%
   LandingPage.vue100%100%100%100%
   NotFoundPage.vue100%100%100%100%
   SubmissionListPage.vue100%100%100%100%
   SubmissionReviewPage.vue100%100%100%100%
   UserLoadingPage.vue100%100%100%100%
src/pages/bceidform
   AddressWizardStep.vue87.50%82.61%84%90.28%137, 156, 160, 192, 49–50, 52, 52–53, 66–67
   BusinessInformationWizardStep.vue75.50%74.80%74.19%76.35%177–179, 194, 194–198, 201, 212, 212–214, 214–216, 219, 223, 226, 226, 226, 226, 226, 226, 226, 226, 226–228, 228, 228, 228–229, 229, 229, 229, 229–230, 232, 245, 256–259, 259, 259, 278, 282, 285, 292, 292–293, 325, 349, 356, 416, 426, 448, 497, 510, 514–515, 58, 93, 99
   ContactWizardStep.vue57.94%61.54%52%58.67%100, 104–106, 108–111, 143, 143, 143, 148, 168, 175, 179, 196, 198, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 83–85, 85–86, 88, 94–96, 96–98
   ReviewWizardStep.vue100%100%100%100%
src/services
   ForestClientService.ts100%100%100%100%

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Frontend e2e Test Coverage

Coverage after merging fix/fe/fix-error-msg into main will be
85.65%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   App.vue85.29%83.33%50%100%62
   CoreConstants.ts100%100%100%100%
   directivesMap.ts100%100%100%100%
   main.ts100%100%100%100%
   routes.ts100%100%100%100%
   shims-vue.d.ts100%100%100%100%
src/components
   DataFetcher.vue100%100%100%100%
   MainHeaderComponent.vue64.89%77.27%10%60%139, 178–181, 190, 202, 202, 202, 222, 235, 246, 257, 44, 44–45, 53, 53, 53, 53–54, 56–58, 58–59, 59, 59–60, 62, 75, 84, 90, 90, 90–91, 93
   UserProfileComponent.vue80%33.33%100%85.71%17, 17, 19, 23
   types.ts100%100%100%100%
src/components/forms
   AutoCompleteInputComponent.vue94.57%91.89%90.48%97.18%179, 208, 68, 81, 83
   DropdownInputComponent.vue99.01%96.43%100%100%111
   MultiselectInputComponent.vue82.29%78.26%72.73%88.24%100, 109, 122, 41, 47, 79–80, 80–82, 89
   RadioInputComponent.vue89.09%75%83.33%96.77%39, 49, 80, 91
   ReadOnlyComponent.vue100%100%100%100%
   TextInputComponent.vue97.30%90.48%100%100%129, 137
src/components/forms/DateInputComponent
   DateInputPart.vue91.67%75%100%100%46, 50
   common.ts100%100%100%100%
   index.vue83.66%73.61%93.75%86.27%1, 1, 108, 117, 120, 122, 137, 149, 203, 218, 225, 269–270, 280–281, 296–298, 300–301, 311–312, 316, 330–333, 340–342, 344–345, 347–348, 350, 352, 352–353, 432, 467
src/components/grouping
   AddressGroupComponent.vue91.25%89.89%97.37%90.27%116, 132, 142, 148, 155–156, 156, 156, 156, 158, 160, 162, 179, 185, 196, 218–219, 235, 266, 311
   ContactGroupComponent.vue97.44%100%96.55%95.65%270, 84, 91
   ErrorNotificationGroupingComponent.vue41.67%16.13%66.67%60%110, 110, 117, 117, 117, 121, 121, 129, 129, 138, 138, 147, 147, 153, 153, 166, 30–31, 31, 34, 58–59, 59, 63, 63–64, 64, 64, 66–67, 67, 69, 73–74, 74, 76, 90, 95, 98, 98
src/composables
   useElementVisibility.ts100%100%100%100%
   useFetch.ts100%100%100%100%
   useFocus.ts100%100%100%100%
   useScreenSize.ts100%100%100%100%
   useSvg.ts100%100%100%100%
src/dto
   ApplyClientNumberDto.ts100%100%100%100%
   CommonTypesDto.ts100%100%100%100%
src/helpers
   CustomDirectives.ts100%100%100%100%
   DataConversors.ts100%100%100%100%
   ForestClientUserSession.ts100%100%100%100%
src/helpers/validators
   BCeIDFormValidations.ts100%100%100%100%
   GlobalValidators.ts100%100%100%100%
   SubmissionValidators.ts100%100%100%100%
src/pages
   ErrorPage.vue25%100%100%25%11–12, 2
   FormBCSCPage.vue83.75%65.67%79.49%91.81%1, 123–124, 145, 231, 293, 295, 304, 319–321, 329, 334, 346, 346, 346, 348–349, 355, 360–362, 365, 365, 429, 51–53, 545, 552, 559, 590, 626, 626, 626, 64, 82
   FormBCeIDPage.vue59.62%52.63%40.63%68.84%1, 1, 1, 1, 1, 100, 102, 105, 116–118, 124, 124–125, 130, 130, 130, 133–134, 140, 247, 249, 258, 268–269, 269, 269, 269, 269, 269–272, 278, 284, 289, 289–294, 308, 308–309, 314, 314–315, 315–316, 316, 321, 327–328, 330, 330–332, 337–339, 349, 352–356, 366, 366, 368–370, 458, 465, 480, 488, 500, 509, 548, 551, 551, 551, 570, 69–71, 95, 99
   FormSubmittedPage.vue61.11%25%0%83.33%12, 30, 32, 32, 32
   LandingPage.vue76.19%42.86%100%92.86%18, 18–19, 48, 58
   SubmissionListPage.vue92.47%80%93.33%96.55%165, 47, 47, 54, 95, 98
   SubmissionReviewPage.vue84.68%80.17%78.85%89.60%1, 103, 103–104, 119, 142, 156–157, 177, 177–180, 184, 184, 198, 221, 221–222, 226, 230, 235, 235–236, 236, 236–237, 241, 247, 266–267, 285, 372, 375, 381, 462, 470, 576, 579, 630, 665, 690
   UserLoadingPage.vue14.29%0%100%20%12, 14, 14, 14–15, 17
src/pages/bceidform
   AddressWizardStep.vue89.17%86.96%84%91.67%137, 156, 160, 192, 49–50, 52, 52–53
   BusinessInformationWizardStep.vue87.42%84.55%93.55%88.51%177–179, 194, 194–198, 201, 226, 226, 226, 226, 228, 228–229, 229, 245, 256–259, 259, 259, 278, 282, 285, 349, 356, 416, 426, 448, 497, 58, 99
   ContactWizardStep.vue57.94%61.54%52%58.67%100, 104–106, 108–111, 143, 143, 143, 148, 168, 175, 179, 196, 198, 40, 40–41, 41, 41, 43–45, 48, 54–55, 64, 83–85, 85–86, 88, 94–96, 96–98
   

@mamartinezmejia mamartinezmejia merged commit 2d3edf9 into main Feb 8, 2024
17 checks passed
@mamartinezmejia mamartinezmejia deleted the fix/fe/fix-error-msg branch February 8, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants