Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe:FSADT1-1006): maximize visible text region on combo-box and autocomplete fields #861

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Mar 12, 2024

Description

Prevents the visible text region from being much smaller then the available space, specially on small width displays, by reducing the padding from 4.5rem to 1rem.

Fixes FSADT1-1006.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions github-actions bot added the fix label Mar 12, 2024
Copy link
Contributor

Current changelog

Bug Fixes

  • maximize visible text region on combo-box and autocomplete fields (9fc7426)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Mar 12, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Mar 12, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@paulushcgcj paulushcgcj merged commit 56efd18 into main Mar 12, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the fix/FSADT1-1006-reflow branch March 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants