Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe:FSADT1-1283): keep the button Next enabled on step 1 #907

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Apr 5, 2024

Description

Remembers the status of individual validation so the button Next stays enabled when the user goes back to step 1.
Also makes sure it gets revalidated if a different individual business gets selected or type of business is changed to Unregistered.

Fixes FSADT1-1283

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions github-actions bot added the fix label Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Current changelog

Bug Fixes

  • make sure to revalidate with user's last name (8bd8b37)
  • remember current status of individual validation (6e56205)

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2024
@fterra-encora fterra-encora marked this pull request as ready for review April 5, 2024 15:02
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Apr 5, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Collaborator

@mamartinezmejia mamartinezmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please named boolean constants with the "Ind" suffix

@github-actions github-actions bot added fix and removed fix labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Apr 8, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora merged commit 2c22125 into main Apr 8, 2024
22 checks passed
@fterra-encora fterra-encora deleted the fix/FSADT1-1283 branch April 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants