Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fe): fetch default error handling #923

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Apr 16, 2024

Description

  • Allows to disable fetch's default error handling;
  • Allows to call the default error handling manually;
  • Updates calls.

Also applies a fix similar to #922 so to validate individual on the BCSC form.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@github-actions github-actions bot added the fix label Apr 16, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

frontend/tests/unittests/composables/useFetch.spec.ts Dismissed Show dismissed Hide dismissed
frontend/tests/unittests/composables/useFetch.spec.ts Dismissed Show dismissed Hide dismissed
frontend/tests/unittests/composables/useFetch.spec.ts Dismissed Show dismissed Hide dismissed
frontend/tests/unittests/composables/useFetch.spec.ts Dismissed Show dismissed Hide dismissed
@github-actions github-actions bot added fix and removed fix labels Apr 16, 2024
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Current changelog

Bug Fixes

  • set to invalid when response is any error except 404 (eac7317)

Features

  • skip fetch default error handling (2403026)

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Apr 16, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora enabled auto-merge (squash) April 16, 2024 20:03
@github-actions github-actions bot removed the fix label Apr 16, 2024
@github-actions github-actions bot added the fix label Apr 16, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@github-actions github-actions bot added fix and removed fix labels Apr 16, 2024
Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora merged commit 91a2d8a into main Apr 16, 2024
22 checks passed
@fterra-encora fterra-encora deleted the fix/fetch-default-error-handling branch April 16, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants