Merge pull request #421 from bcgov/test-logging

remove debug logs, update user error check
bcgov · Oct 19, 2023 · acbefc0 · acbefc0
2 parents 8e2dafc + c13c79d
commit acbefc0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/app/client/src/utilities/api.ts b/app/client/src/utilities/api.ts
@@ -58,8 +58,6 @@ async function request(
       err.response.data.code &&
       err.response.data.description
     ) {
-      console.log(err.response.data);
-      console.log(err.response.data.description);
       return Promise.reject(
         new ApiError(err.response.data.code, err.response.data.description)
       );

diff --git a/app/server/middleware/roleValidation.js b/app/server/middleware/roleValidation.js
@@ -20,7 +20,7 @@ module.exports = function (roles) {
   return async function (req, res, next) {
     try {
       const data = await fetchUser(req.currentUser.idir_username.toUpperCase());
-      if (data !== undefined) {
+      if (data !== undefined && data !== null) {
         const logical = user.convertToLogicalModel(data);
 
         if (roles.some((role) => logical.roleId === role)) {