Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [NMP-83] Add basic keycloak #85

Merged
merged 22 commits into from
Dec 10, 2024
Merged

feat: [NMP-83] Add basic keycloak #85

merged 22 commits into from
Dec 10, 2024

Conversation

raarielgrace
Copy link
Contributor

@raarielgrace raarielgrace commented Dec 5, 2024 •
edited by github-actions bot
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Added keycloak packages and integrated with the frontend and backend code
  • Added basic login/logout button with changing text based on status (keycloak doesn't affect anything else currently)
  • Copied over global error handler from ENV-ALERT project

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@raarielgrace raarielgrace linked an issue Dec 5, 2024 that may be closed by this pull request
Add keycloak SSO plugins to FE and BE #83
Closed
3 tasks
@raarielgrace raarielgrace force-pushed the 83-add-keycloak branch 2 times, most recently from 581f034 to c8de1e4 Compare December 6, 2024 20:32
dallascrichmond
dallascrichmond approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@dallascrichmond dallascrichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great :)

@raarielgrace raarielgrace merged commit 78b5714 into main Dec 10, 2024
15 checks passed
@raarielgrace raarielgrace deleted the 83-add-keycloak branch December 10, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallascrichmond dallascrichmond dallascrichmond approved these changes

@lunamoonmoon lunamoonmoon Awaiting requested review from lunamoonmoon lunamoonmoon is a code owner

@fergmac fergmac Awaiting requested review from fergmac fergmac is a code owner

@PaulGarewal PaulGarewal Awaiting requested review from PaulGarewal PaulGarewal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add keycloak SSO plugins to FE and BE
2 participants
@raarielgrace @dallascrichmond