Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [NMP-79] Frontend State Management #92

Merged
merged 17 commits into from
Dec 10, 2024
Merged

feat: [NMP-79] Frontend State Management #92

merged 17 commits into from
Dec 10, 2024

Conversation

dallascrichmond
Copy link
Collaborator

@dallascrichmond dallascrichmond commented Dec 10, 2024 •
edited by github-actions bot
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • If the user uploads an .nmp file it will be saved to localstorage and can be access through the app easily via state

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@dallascrichmond dallascrichmond linked an issue Dec 10, 2024 that may be closed by this pull request
Frontend State Management #79
Closed
1 task
PaulGarewal
PaulGarewal approved these changes Dec 10, 2024
View reviewed changes
Copy link

@PaulGarewal PaulGarewal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 👍 This is going to be so much cleaner and more scalable

@dallascrichmond dallascrichmond merged commit 472690b into main Dec 10, 2024
15 checks passed
@dallascrichmond dallascrichmond deleted the NMP-79-State-Management branch December 10, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulGarewal PaulGarewal PaulGarewal approved these changes

@lunamoonmoon lunamoonmoon Awaiting requested review from lunamoonmoon lunamoonmoon is a code owner

@fergmac fergmac Awaiting requested review from fergmac fergmac is a code owner

@raarielgrace raarielgrace Awaiting requested review from raarielgrace raarielgrace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend State Management
2 participants
@dallascrichmond @PaulGarewal