Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed cors from express #43

Merged
merged 2 commits into from
Oct 5, 2023
Merged

removed cors from express #43

merged 2 commits into from
Oct 5, 2023

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Oct 4, 2023

Description

Removed CORS from Express
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

@DerekRoberts DerekRoberts marked this pull request as draft October 4, 2023 17:37
@DerekRoberts DerekRoberts reopened this Oct 4, 2023
@DerekRoberts DerekRoberts reopened this Oct 4, 2023
@DerekRoberts DerekRoberts added the enhancement New feature or request label Oct 4, 2023
@DerekRoberts DerekRoberts marked this pull request as ready for review October 5, 2023 18:44
@jazzgrewal jazzgrewal merged commit db35093 into main Oct 5, 2023
34 of 38 checks passed
@jazzgrewal jazzgrewal deleted the fix/corsPolicy branch October 5, 2023 18:49
DerekRoberts added a commit that referenced this pull request May 1, 2024
* removed cors from express

* Caddyfile + VITE_AWS_DOMAIN

---------

Co-authored-by: Derek Roberts <[email protected]>
DerekRoberts added a commit that referenced this pull request May 3, 2024
* removed cors from express

* Caddyfile + VITE_AWS_DOMAIN

---------

Co-authored-by: Derek Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants