Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: envar-controlled connection settings #252

Closed
DerekRoberts opened this issue Feb 27, 2024 · 0 comments · Fixed by #257
Closed

feat: envar-controlled connection settings #252

DerekRoberts opened this issue Feb 27, 2024 · 0 comments · Fixed by #257
Assignees
Labels
enhancement New feature or request

Comments

@DerekRoberts
Copy link
Member

DerekRoberts commented Feb 27, 2024

https://github.com/bcgov/nr-silva/blob/main/backend/src/main/resources/application.properties#L31-L33

spring.datasource.hikari.minimumIdle = 1
spring.datasource.hikari.maximumPoolSize = 3

via @mishraomp:

move these to env vars
and really bump these up in production
based on the load
may be to 5 or 8 per pod
and get the final number after tuning and put env specific values
may be 2 or 3 in dev and 5 in TEST and 8 in prod
@DerekRoberts DerekRoberts added the enhancement New feature or request label Feb 27, 2024
@DerekRoberts DerekRoberts self-assigned this Feb 27, 2024
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Feb 27, 2024
@DerekRoberts DerekRoberts linked a pull request Feb 27, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant