Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): set min and max db (oracle) connections #257

Merged
merged 1 commit into from
Feb 27, 2024
Merged

chore(ci): set min and max db (oracle) connections #257

merged 1 commit into from
Feb 27, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Feb 27, 2024 •
edited by github-actions bot
Loading

We've been running out of connections. This puts connection pool settings into envars, making a cap=1 easier for PRs.

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-257-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-7-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@DerekRoberts DerekRoberts marked this pull request as ready for review February 27, 2024 22:46
@DerekRoberts DerekRoberts self-assigned this Feb 27, 2024
@DerekRoberts DerekRoberts added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Feb 27, 2024
@DerekRoberts DerekRoberts linked an issue Feb 27, 2024 that may be closed by this pull request
feat: envar-controlled connection settings #252
Closed
mishraomp
mishraomp approved these changes Feb 27, 2024
View reviewed changes
Copy link

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DerekRoberts DerekRoberts enabled auto-merge (squash) February 27, 2024 22:52
@DerekRoberts DerekRoberts merged commit 44e45e3 into main Feb 27, 2024
12 checks passed
@DerekRoberts DerekRoberts deleted the chore/ci/connectionVars branch February 27, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

@RMCampos RMCampos Awaiting requested review from RMCampos

Assignees

@DerekRoberts DerekRoberts

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: envar-controlled connection settings
2 participants
@DerekRoberts @mishraomp