generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Java REST API in the back end #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #91 This commit adds initial files generated by start.spring.io website where the project was generated with: - Project: Maven - Language: Java - Spring Boot version: 3.1.3 (latest stable) - Project metadata group: ca.bc.gov.restapi - Project metadata artifact: results - Project metadata name: results - Project metadata description: RESULTS REST API - Packaging: Jar - Java version: 17 - Dependencies - Actuator - Data JPA - OAuth2 Authorization server - OAuth2 client - Started web - Devtools - H2 Database - Lombok - GraalVM
Issue #91 Adding the maven wrapper is a good practice, recommended in case you want to use maven out of the box.
Issue #91 This change adds required dependencies for building, running and packaging the service locally and for Cloud Native images. This is what was changed: - Add project license - Add properties and definitions - Add profiles for dev, prod and native - Add dependencies - Add plugins for building, running and packaging - Add project final name jar, line 179
Issue #91 This commit adds the google checkstyle xml definition file to be used as a guide for the checkings. Also updates existing class files to met the checkstyle validations, replacing tab by spaces, adding JavaDoc to all public classes.
Issue #91 This change adds a new service to the docker-compose file for the backend REST api. If you want to run the backend locally all you need is to run at the project root folder: `docker compose up backend` and you're all set. Other minor changes were made: - Add some properties to the application properties file - Remove dependencies not required for now
Issue #91 This change gets tests passing and cloud native build working and running smoothly.
Issue #91 This change simply add more information on the new service in the back end.
Issue #91 This change updates the Spring Boot version to the latest (at the time of this writing), which is 3.1.4. And also updates the required Java version required to compile and run this service, which is the 21.
Issue #91 This commit updates the existing docker-compose file to use the latest maven with Java 21 available at this moment.
11 tasks
DerekRoberts
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. :)
Hmm.. Just saw that Trivy security alert. I'll take a look |
Issue #91 This change simply change the required version by spring boot of this dependency. You can learn more about it here: - spring-projects/spring-boot#32221 - https://avd.aquasec.com/nvd/2022/cve-2022-1471/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a REST API with Spring Boot. Features:
Fixes #91
Type of change
How Has This Been Tested?
This was tested locally.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Frontend
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow