Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add backend FAM authentication #243

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Feb 8, 2024

Description

Add FAM authentication in the backend.

⚠️ Note that from now on, everytime you go to Swagger UI you'll have to input a JWT token.

Fixes Jira ticket SILVA-313

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested running locally and with unit tests.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-243-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-43-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Feb 8, 2024
@DerekRoberts
Copy link
Member

@RMCampos Can we get around the token just for visiting Swagger? And a health checkpoint?

@RMCampos
Copy link
Author

RMCampos commented Feb 8, 2024

@RMCampos Can we get around the token just for visiting Swagger? And a health checkpoint?

Hmm.. Usually we keep authentication required for Swagger. As for the health checkpoint that's not required, my bad. Only requests under /api will have to send a bearer token. @DerekRoberts

@DerekRoberts
Copy link
Member

@RMCampos Great, thanks!. :)

feat: get current user id from token
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I took a very surface-level look while scrubbing the console and logs. :)

Copy link
Collaborator

@jazzgrewal jazzgrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@RMCampos RMCampos merged commit 952ad02 into main Feb 9, 2024
12 checks passed
@RMCampos RMCampos deleted the feat/313-add-backend-fam-authentication branch February 9, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants