generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create favourite openings api #266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jira issue silva-331
RMCampos
changed the base branch from
main
to
feat/331-create-openings-per-year-api
April 2, 2024 20:41
jira issue silva-358
DerekRoberts
approved these changes
Apr 9, 2024
DerekRoberts
approved these changes
Apr 9, 2024
@DerekRoberts code coverage on the way. I'll be pushing more unit tests tomorrow 🚀 |
@DerekRoberts much better now 😄 |
DerekRoberts
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Go @RMCampos! :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create APIs to handle User Favourite Openings.
Fixes Jira task SILVA-358
Type of change
How Has This Been Tested?
Tested locally on Swagger-UI and with unit tests.
Checklist
Further comments
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend: https://nr-silva-266-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-16-frontend.apps.silver.devops.gov.bc.ca
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow