Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create favourite openings api #266

Merged
merged 22 commits into from
Apr 11, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Apr 2, 2024

Description

Create APIs to handle User Favourite Openings.

Fixes Jira task SILVA-358

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally on Swagger-UI and with unit tests.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-266-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-16-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Apr 2, 2024
@RMCampos RMCampos changed the base branch from main to feat/331-create-openings-per-year-api April 2, 2024 20:41
Base automatically changed from feat/331-create-openings-per-year-api to main April 2, 2024 20:45
@RMCampos RMCampos marked this pull request as ready for review April 9, 2024 18:09
@RMCampos
Copy link
Author

RMCampos commented Apr 9, 2024

@DerekRoberts code coverage on the way. I'll be pushing more unit tests tomorrow 🚀

image

@RMCampos
Copy link
Author

image

@DerekRoberts much better now 😄

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Go @RMCampos! :D

@RMCampos RMCampos merged commit 683b825 into main Apr 11, 2024
14 checks passed
@RMCampos RMCampos deleted the feat/358-create-favourite-openings-api branch April 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants