Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add lint check to CI #320

Merged
merged 2 commits into from
May 30, 2024
Merged

chore: add lint check to CI #320

merged 2 commits into from
May 30, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented May 29, 2024

Description

Add lint job to detect possible issues.

Fixes Jira Ticket SILVA-399

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This was tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-320-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-20-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this May 29, 2024
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! If all pans out maybe I can add this to the existing test actions. Please expect your ideas stolen. ;)

@RMCampos
Copy link
Author

RMCampos commented May 29, 2024

@DerekRoberts @jazzgrewal

P.S.: note that this PR just adds the lint job. The fixes (and test cases) will be addressed in future changes.
P.P.S.: all changed files were changed running npm run lint:fix to make sure the command works, we can either remove them for the PR (they will not be covered with tests right now) or we can keep it as an a start point for the fixes.

@RMCampos RMCampos changed the title chore: add eslintrc json file and lint to the pipeline chore: add lint check to CI May 29, 2024
@DerekRoberts
Copy link
Member

DerekRoberts commented May 29, 2024

@RMCampos Try this just to get through the PR? npm run lint || true

@RMCampos RMCampos merged commit 0e1d85b into main May 30, 2024
16 checks passed
@RMCampos RMCampos deleted the fix/silva-399-linting-workflow branch May 30, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants