Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-554): removing notification from landing page #433

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Oct 30, 2024

Description

The login page notification is a good way to communicate with users about the current status of the application, but as it is not yet completed, it is better to be removed until the implementation is complete.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-433-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-33-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate, but understandable.

Copy link
Collaborator

@carolinemwood carolinemwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed by Caroline Wood and approved

@paulushcgcj paulushcgcj merged commit ca02291 into main Oct 30, 2024
16 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-554 branch October 30, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants