Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userRecentOpenings): (SILVA-570) stop retry if no user recent openings present #474

Closed
wants to merge 4 commits into from

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Nov 19, 2024

Description

This PR fixes the issue for the feature release SILVA-570, in which when the user lands on the home Page, if they dont have any openings, it should not keep rretryin 3 times ot fetch the data from the server.
Fixes # (SILVA-570)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested Locally

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-474-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-24-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@jazzgrewal jazzgrewal changed the title fix(SILVA-570):userRecentOpenings stop retry if no user recent openings present fix:(SILVA-570)userRecentOpenings stop retry if no user recent openings present Nov 20, 2024
@jazzgrewal jazzgrewal changed the title fix:(SILVA-570)userRecentOpenings stop retry if no user recent openings present fix(userRecentOpenings): (SILVA-570) stop retry if no user recent openings present Nov 20, 2024
@jazzgrewal jazzgrewal closed this Nov 20, 2024
@jazzgrewal
Copy link
Collaborator Author

This change was already accepted by @paulushcgcj when rebasing to main.

@paulushcgcj paulushcgcj deleted the fix/nouserRecentOpenings branch November 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants