fix(SILVA-511): fixing opening map popup #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help future refactors by centralizing api configuration, such as URLs and basic headers
refactored file to use the api config file, and added the new check endpoint
refactored file to use the newly defined api config
Added new component that handles the opening popup content along with the favourite handling.
paulushcgcj
requested review from
carolinemwood,
jazzgrewal,
DerekRoberts and
gpascucci
as code owners
DerekRoberts
previously approved these changes
Nov 22, 2024
The new query was having a hard time to parse the opening id list as part of the huge query. Broke it into a smaller one
|
Closes #462 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed appearance to reflect figma and added the favourite handling
Type of change
Please delete options that are not relevant.
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: