Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-577): perform search on hitting enter key #504

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Nov 25, 2024

Description

In this PR we have added the UX improvement, where a user can perform search by hitting the enter key on the search bar, while they are typing, earlier they were required to click the search button in order to make the search happen.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested Locally
  • Unit test

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@jazzgrewal jazzgrewal merged commit 458602d into main Nov 25, 2024
21 checks passed
@jazzgrewal jazzgrewal deleted the fix/searchOnEnter branch November 25, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants