Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SILVA-539): added autocomplete for client location #505

Merged
merged 26 commits into from
Dec 2, 2024
Merged

feat(SILVA-539): added autocomplete for client location #505

merged 26 commits into from
Dec 2, 2024

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Nov 25, 2024 •
edited by github-actions bot
Loading

Description

Added autocomplete for client location

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@paulushcgcj
feat(SILVA-539): added search by acronym, name or number on FC api
c28747a
@paulushcgcj
feat(SILVA-539): added backend code to do client search
bb71446
@paulushcgcj
feat(SILVA-539): added frontend code to do client search
0e4956e
@paulushcgcj
Merge branch 'main' into feat/SILVA-539
f17a4a5
@paulushcgcj
Merge branch 'main' into feat/SILVA-539
dfc77a9
@paulushcgcj
fix(SILVA-539): fixing lodash issues
0849cc5
@paulushcgcj
Merge branch 'main' into feat/SILVA-539
98c4d63
@paulushcgcj
chore(SILVA-539): increasing the size of locations page
b29c6c2 
This is to account for locations with more than 10 entries. Limit is usually 50 per client but we never know
@paulushcgcj
feat(SILVA-539): adding search with location code as param
feef21f
@paulushcgcj
chore: fixing test
197f705
@paulushcgcj
Merge remote-tracking branch 'origin/feat/SILVA-539' into feat/SILVA-539
1c2db7d
@paulushcgcj
feat(SILVA-539): adding changes to frontend
b318040
@paulushcgcj
Merge branch 'main' into feat/SILVA-539
fa2ff42
@paulushcgcj paulushcgcj marked this pull request as ready for review November 28, 2024 19:54
carolinemwood
carolinemwood approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@carolinemwood carolinemwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by PO

@paulushcgcj paulushcgcj enabled auto-merge (squash) December 2, 2024 13:01
@paulushcgcj paulushcgcj merged commit efd2d74 into main Dec 2, 2024
23 checks passed
@paulushcgcj paulushcgcj deleted the feat/SILVA-539 branch December 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinemwood carolinemwood carolinemwood approved these changes

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

@gpascucci gpascucci Awaiting requested review from gpascucci gpascucci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulushcgcj @DerekRoberts @carolinemwood