Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SILVA-575): fixing modal on recent openings #515

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

paulushcgcj
Copy link
Contributor

@paulushcgcj paulushcgcj commented Dec 2, 2024

Description

Fixing modal on recent openings

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@gpascucci gpascucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i noticed there were some unchanged files with check annotations, highlighting things like unused imports and unnecessary trailing commas.

@paulushcgcj
Copy link
Contributor Author

i noticed there were some unchanged files with check annotations, highlighting things like unused imports and unnecessary trailing commas.

Yeah, this will be fixed soon. Lots and lots of tech debt

@paulushcgcj paulushcgcj merged commit 38836be into main Dec 2, 2024
22 checks passed
@paulushcgcj paulushcgcj deleted the fix/SILVA-575 branch December 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants