Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update carbon design class prefix changed #87

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: update carbon design class prefix changed #87

merged 1 commit into from
Sep 6, 2023

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Sep 6, 2023 •
edited by github-actions bot
Loading

Description

Fix broken Carbon Design style.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This was tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

fix: update carbon design class prefix changed
2d5a905 
No issue related.

This webapp has being using kind of a default class prefix for providing
all css classes the same name, however that class got changed, from
'bcgov' to 'bx' on @bcgov-nr/nr-fsa-theme design-token variable file.
@RMCampos RMCampos requested a review from jazzgrewal as a code owner September 6, 2023 19:36
@RMCampos RMCampos self-assigned this Sep 6, 2023
DerekRoberts
DerekRoberts approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small PRs. :D + :P

@DerekRoberts DerekRoberts merged commit 072a4f4 into main Sep 6, 2023
8 checks passed
@DerekRoberts DerekRoberts deleted the fix/carbon-theme-class-prefix branch September 6, 2023 19:43
DerekRoberts pushed a commit that referenced this pull request Sep 6, 2023
@DerekRoberts
fix: update carbon design class prefix changed (#87)
04eb95a 
No issue related.

This webapp has being using kind of a default class prefix for providing
all css classes the same name, however that class got changed, from
'bcgov' to 'bx' on @bcgov-nr/nr-fsa-theme design-token variable file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

Assignees

@RMCampos RMCampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RMCampos @DerekRoberts