Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the sizing issue for the themeToglle button to align with the Figma design #89

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jazzgrewal
Copy link
Collaborator

@jazzgrewal jazzgrewal commented Sep 8, 2023

Description

Fixed the sizing issues with the themeToggle button

Fixes # SILVA-137

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Docker Compose Local

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.
Frontend

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@jazzgrewal jazzgrewal merged commit 8dde5cb into main Sep 8, 2023
8 checks passed
@jazzgrewal jazzgrewal deleted the fix/toggleButton branch September 8, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants