feat: 1520 404 page not found screen development #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ngunner15
requested review from
RMCampos,
mgaseta,
DerekRoberts and
SLDonnelly
as code owners
RMCampos
approved these changes
Oct 11, 2024
|
Working like a charm |
mgaseta
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Looking good! Nice job!
Besides the markups, there are 2 issues:
- On the design, the navigation header is still present on the 404 page (here)
- The page is not being redirected to the 404, you can see that by looking at the URL, it doesn't change to
/404, not exactly necessary, but it would be nice to change the URL to reflect the correct page.
|
Looks good! Responsiveness working well. Thanks Nisarg |
mgaseta
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1520
Test URL for 404 page - https://nr-spar-13-frontend.apps.silver.devops.gov.bc.ca/404
Changelog
New
Changed
Removed
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: