fix: added migration file to fix discrepancies #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franTarkenton
requested review from
xiaopeng0202,
mgaseta,
DerekRoberts and
SLDonnelly
as code owners
DerekRoberts
approved these changes
Dec 3, 2024
xiaopeng0202
approved these changes
Dec 4, 2024
…ration definitions
franTarkenton
force-pushed
the
feat/1764-db-migration-fix
branch
from
9703876 to
2af5faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes a migration file that will result in new databases created from the migrations to have the same structure as what is currently implemented in our physical TEST / PROD databases. The migration has conditionals attached which should prevent the existing database from being modified.
Closes #1764
Changelog
New
Changed
Removed
How was this tested?
Tested by running net new migration using local env. Confirmed that this has the same structure as what exists in the physical implementations of TEST / PROD (spar2). Then deleted the V46 record from the flyway migration table and re-ran the migrations. This simulates the conditions for running this migration on the physical db's TEST / PROD. Verified that the migrations did not crash or otherwise alter the structure of the tables.
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: