Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: [BB-191] Feature** Fields and Soil Stage 2 #192

Merged
merged 35 commits into from
Jun 22, 2024

Conversation

kcaparas1630
Copy link
Contributor

@kcaparas1630 kcaparas1630 commented Jun 19, 2024

Description

This is stage 2 of the implementation of Fields and Soil. It should do one of the following

Given that I have no data regarding the fields

  • Display three input fields (FieldName, Area, Comments)
  • I'll be able to add them into the farm details object and show display that into a list.

Given that I have an input now

  • It should create a list containing the data that the user inputted
  • Be able to add a new list
  • Option to go to next form module, or go back to recent form module

Mockups Reference:

image

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Depending on how big this pull request might explode, some of its implementation might be broken down and pushed to the next stage of this pull request. For example, functionality of the edit, cancel, trash, and etc.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@kcaparas1630 kcaparas1630 marked this pull request as ready for review June 21, 2024 01:39
@kcaparas1630
Copy link
Contributor Author

It's finally ready! I've self reviewed and cleaned it up!

@kcaparas1630
Copy link
Contributor Author

Forgive me for the long pr, it's within good reason. I've fixed some of my bugs in this pr and it should be working.
P.S. Edit Button and Trash Button are not implemented yet.

@kcaparas1630 kcaparas1630 requested a review from LocalNewsTV June 21, 2024 01:45
@kcaparas1630 kcaparas1630 linked an issue Jun 21, 2024 that may be closed by this pull request
5 tasks
Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a little deeper dive in a bit, but wanted to leave you with this one comment first

frontend/src/Commons/Button/Button.style.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things are definitely coming along, but a little more work needs to be done to get there completely :)

Copy link
Contributor

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the hardest task on this Sprint, you're doing a great job so far!
Keep it going!

There are some minor adjustments I'm suggesting and the styling seems a bit off. I saw a bunch of position: relative and position: absolute which I rarely use and am not sure if could be causing some of this. But this is what I got on mobile:

image

It's probably a width somewhere that's skewing everything.

Still, I really like your organization, consistency and overall implementation. Kudos on the modularity of implementation.
Keep up the good work!

frontend/package.json Outdated Show resolved Hide resolved
frontend/src/Commons/Button/Button.style.ts Show resolved Hide resolved
frontend/src/Commons/Button/Button.tsx Show resolved Hide resolved
frontend/src/Commons/Button/Button.tsx Show resolved Hide resolved
frontend/src/Commons/Input/ErrorMessage.css Show resolved Hide resolved
frontend/src/Constants/ComponentText.ts Outdated Show resolved Hide resolved
frontend/src/Interface/FieldDetailsInterface.tsx Outdated Show resolved Hide resolved
@kcaparas1630
Copy link
Contributor Author

Did the changes. Let me know what else I needed to do.

Copy link
Contributor

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fire mate! Keep it going!
🔥 🚀 🔥

frontend/src/Constants/ComponentText.ts Show resolved Hide resolved
@kcaparas1630 kcaparas1630 merged commit c9f8f30 into main Jun 22, 2024
15 checks passed
@kcaparas1630 kcaparas1630 deleted the BB-191-Implement-Fields-And-Soil-Functionality branch June 22, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Fields and Soil Functionality - Stage 2
3 participants