-
Notifications
You must be signed in to change notification settings - Fork 2
feat: [BB-191] Feature** Fields and Soil Stage 2 #192
feat: [BB-191] Feature** Fields and Soil Stage 2 #192
Conversation
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
…ne-2024 into BB-191-Implement-Fields-And-Soil-Functionality
It's finally ready! I've self reviewed and cleaned it up! |
Forgive me for the long pr, it's within good reason. I've fixed some of my bugs in this pr and it should be working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a little deeper dive in a bit, but wanted to leave you with this one comment first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things are definitely coming along, but a little more work needs to be done to get there completely :)
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsButtonComponent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsListComponent.styles.ts
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsListComponent.styles.ts
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsListComponent.styles.ts
Outdated
Show resolved
Hide resolved
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsListComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the hardest task on this Sprint, you're doing a great job so far!
Keep it going!
There are some minor adjustments I'm suggesting and the styling seems a bit off. I saw a bunch of position: relative
and position: absolute
which I rarely use and am not sure if could be causing some of this. But this is what I got on mobile:
It's probably a width
somewhere that's skewing everything.
Still, I really like your organization, consistency and overall implementation. Kudos on the modularity of implementation.
Keep up the good work!
frontend/src/Commons/Forms/InputModules/FieldsAndSoil/FieldsAndSoil.tsx
Outdated
Show resolved
Hide resolved
Did the changes. Let me know what else I needed to do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're on fire mate! Keep it going!
🔥 🚀 🔥
Description
This is stage 2 of the implementation of Fields and Soil. It should do one of the following
Mockups Reference:
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Depending on how big this pull request might explode, some of its implementation might be broken down and pushed to the next stage of this pull request. For example, functionality of the edit, cancel, trash, and etc.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: