-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self Reviewed 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my perspective, I haven't seen anything bad in this ticket. It's an export page draft, that deletes localStorage data when download is pressed for the meantime. It does it job.
However, there are some warnings that displays in the console. If you can change textArea's initial values to just an empty string instead of a null. Since, it's accepting a string anyways, and it still indicates that no values was entered.
Another warning that I'm getting in my console regarding keys. I'm pretty sure it's because of this line here in the Summary.tsx
{farmDetails.Fields.map((field) => (
<div key={field.FieldName}>
<p>{field.FieldName}</p>
<p>{field.Area}</p>
<p>{field.Comments}</p>
</div>
))}
You can do this instead
<div key={index}>
<p>{field.FieldName}</p>
<p>{field.Area}</p>
<p>{field.Comments}</p>
</div>
))}```
Anyways, this is not part of this ticket, so I'll bug you elsewhere. Good work! 🚀
Description
Qucik and dirty Export page. Just took a bunch of stuff from the Landing Page and MAin Page to make this quickly.
We want to start work on exporting asap!
Type of changes
Please delete options that are not relevant.
Checklist
Further comments
Demo
Mockup
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: