Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

feat: Quick and Dirty Export page #194

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Conversation

GDamaso
Copy link
Contributor

@GDamaso GDamaso commented Jun 20, 2024

Description

Qucik and dirty Export page. Just took a bunch of stuff from the Landing Page and MAin Page to make this quickly.
We want to start work on exporting asap!

Type of changes

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Demo

ExportPageDemo

Mockup

image


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@GDamaso GDamaso linked an issue Jun 20, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor Author

@GDamaso GDamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self Reviewed 👌

@GDamaso GDamaso marked this pull request as ready for review June 20, 2024 02:14
@GDamaso GDamaso changed the title Quick and Dirty Export page feat: Quick and Dirty Export page Jun 20, 2024
frontend/src/Views/Export/ExportPage.tsx Outdated Show resolved Hide resolved
frontend/src/Views/Export/ExportPage.tsx Outdated Show resolved Hide resolved
frontend/src/Views/Export/ExportPage.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kcaparas1630 kcaparas1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my perspective, I haven't seen anything bad in this ticket. It's an export page draft, that deletes localStorage data when download is pressed for the meantime. It does it job.

However, there are some warnings that displays in the console. If you can change textArea's initial values to just an empty string instead of a null. Since, it's accepting a string anyways, and it still indicates that no values was entered.
image

Another warning that I'm getting in my console regarding keys. I'm pretty sure it's because of this line here in the Summary.tsx

{farmDetails.Fields.map((field) => (
        <div key={field.FieldName}>
          <p>{field.FieldName}</p>
          <p>{field.Area}</p>
          <p>{field.Comments}</p>
        </div>
      ))}

You can do this instead

  <div key={index}>
    <p>{field.FieldName}</p>
    <p>{field.Area}</p>
    <p>{field.Comments}</p>
  </div>
))}```


Anyways, this is not part of this ticket, so I'll bug you elsewhere. Good work! 🚀 

@GDamaso GDamaso merged commit b733dc6 into main Jun 20, 2024
15 checks passed
@GDamaso GDamaso deleted the BB-149-implement-export-page branch June 20, 2024 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Export Page
3 participants