Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate multiple vuex stores to pinia #256

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Migrate multiple vuex stores to pinia #256

merged 9 commits into from
Jan 28, 2025

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Jan 20, 2025

This is This is the first half of the migration from vuex to pinia stores #242

@Gavinok Gavinok requested review from esune and amanji January 20, 2025 20:17
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good overall, looking forward to the end result 🙂

src/store/modules/entity.ts Outdated Show resolved Hide resolved
src/components/entity/EntityResult.vue Outdated Show resolved Hide resolved
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok Gavinok requested a review from esune January 27, 2025 22:29
@esune esune merged commit 2aa729d into main Jan 28, 2025
3 checks passed
@esune esune deleted the migrate-to-vite branch January 28, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants