26014 - auth web permissions updates #3290
Conversation
ochiu
force-pushed
the
26014-auth-web-permissions-updates
branch
from
282fb32 to
3c1a8f0
Compare
| @@ -131,7 +131,7 @@ | |||
| class="value" | |||
| aria-labelledby="adminContact" | |||
| > | |||
| <OrgAdminContact /> | |||
| <OrgAdminContact :orgId="orgId"/> | |||
There was a problem hiding this comment.
Fix page refresh where the contact refreshes to the current accounts contact rather than the account on the current url
| @@ -591,8 +590,6 @@ export default defineComponent({ | |||
| } | |||
|
|
|||
| onMounted(async () => { | |||
| const accountSettings = getAccountFromSession() | |||
| await orgStore.syncOrganization(accountSettings?.id) | |||
There was a problem hiding this comment.
Let the higher level sync from account settings(takes orgId path param now) take care of this or it conflicts with the orgId on the url on refresh.
| sortable: false | ||
| } | ||
| ] | ||
| export default defineComponent({ |
There was a problem hiding this comment.
To composition-api which handled refresh / syncing issues
| @@ -88,10 +87,6 @@ export default class PendingMemberDataTable extends Vue { | |||
| } | |||
| ] | |||
|
|
|||
| private canApproveOrDeny (): boolean { | |||
There was a problem hiding this comment.
can be consistent now with some of the current invitation updates to use permissions.
| @@ -188,13 +188,6 @@ export default defineComponent({ | |||
| }) | |||
|
|
|||
| const credit = ref(0) | |||
|
|
|||
| const isTransactionsAllowed = computed((): boolean => { | |||
There was a problem hiding this comment.
no longer needed. Permissions will hide/show this based on 'transaction_history' permission, this has been updated for the auth-api portion. API blocks if there are no appropriate security roles.
| v-for="tab in tabs" | ||
| :key="tab.code" | ||
| :data-test="tab.code" | ||
| :to="tab.page" |
There was a problem hiding this comment.
Lot of weird artifacts with all the explicit v-tabs along with v-can permission updates. Refactored to use tab config that is built on permissions when loading up and iterates over to render them
| this.currentOrganization?.statusCode === AccountStatus.INACTIVE | ||
| ) | ||
| } | ||
|
|
||
| private async mounted () { | ||
| await this.syncOrganization(this.orgId) | ||
| await this.syncMembership(this.orgId) |
There was a problem hiding this comment.
Refresh bug fix, based on path param rather that currentOrg in the state
| @@ -154,7 +154,8 @@ | |||
|
|
|||
| <!-- Continuation Applications --> | |||
| <v-card | |||
| v-can:VIEW_CONTINUATION_AUTHORIZATION_REVIEWS.hide | |||
| v-if="canViewContinuationAuthorization" | |||
There was a problem hiding this comment.
Fix where legal api is still called even though this is hidden
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-test-3290-2juml0kn.web.app |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3290-a2e8xhf3.web.app |
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-test-3290-2juml0kn.web.app |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3290-a2e8xhf3.web.app |
|
Holding off on merging. Discussed with Ken and he will do some initial regression on Staff permissions so he can use the same data set to compare against in DEV and gcbrun DEV |
|
|
/gcbrun |
|
Temporary Url for review: https://bcregistry-account-dev--pr-3290-a2e8xhf3.web.app |
|
Temporary Url for review: https://bcregistry-account-dev--pr-test-3290-2juml0kn.web.app |
Issue #:
bcgov/entity#26014
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).