Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpError "Not found" #33

Closed
cisaacson opened this issue Dec 18, 2019 · 3 comments · May be fixed by #35
Closed

HttpError "Not found" #33

cisaacson opened this issue Dec 18, 2019 · 3 comments · May be fixed by #35

Comments

@cisaacson
Copy link

cisaacson commented Dec 18, 2019 •
edited
Loading

I am getting this error using node-pre-gyp-github version 1.4.3:

(node:23711) UnhandledPromiseRejectionWarning: HttpError: {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/releases/#list-releases-for-a-repository"}
    at response.text.then.message (/Users/coryisaacson/git/rtip-rs/flatbuffer-idl-parser-js/node_modules/node-pre-gyp-github/node_modules/@octokit/rest/lib/request/request.js:72:19)
    at process._tickCallback (internal/process/next_tick.js:68:7)

I saw this was an issue with an earlier release but I'm getting it now with this one. I am installed @octokit/rest": "^16.35.2 to ensure I have the latest.

Any recommendations appreciated. I have a valid github token and the repo is definitely valid too.
@cisaacson
Copy link
Author

cisaacson commented Dec 18, 2019 •
edited
Loading

I changed the token rights to full repo access and it worked. Would be good to update the documentation. If someone can confirm the required token rights I am happy to provide a pull request for the doc.

@Richienb
Copy link
Collaborator

In order for the script to access a public repository to update the assets, you need to select the public_repo scope.

@Richienb Richienb mentioned this issue Oct 28, 2020
Draft
@daniellockyer
Copy link
Collaborator

Closing this as the documentation lists the public_repo scope 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Richienb/node-pre-gyp-github
3 participants
@daniellockyer @cisaacson @Richienb