Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #35

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Refactor #35

wants to merge 4 commits into from

Conversation

Richienb
Copy link
Collaborator

@Richienb Richienb commented Oct 28, 2020

In this PR, I refactored the codebase in Typescript. The last thing to migrate is the tests.

If you want some help maintaining this repo, feel free to add me as a maintainer on GitHub and npm.

// @bchr02

Fixes: #32, Fixes: #33

Signed-off-by: Richie Bendall <[email protected]>
Signed-off-by: Richie Bendall <[email protected]>
@Richienb Richienb marked this pull request as draft October 28, 2020 08:31
@bchr02
Copy link
Owner

bchr02 commented Oct 28, 2020

Hi @Richienb. Yes, I would love your assistance to maintain this repo. I just added you as a contributor. Thank you!

@bchr02
Copy link
Owner

bchr02 commented Nov 10, 2020

In this PR, I refactored the codebase in Typescript. The last thing to migrate is the tests.

If you want some help maintaining this repo, feel free to add me as a maintainer on GitHub and npm.

// @bchr02

Fixes: #32, Fixes: #33

@Richienb did you see my last message? I went ahead and added you to this repo as a maintainer. I tried looking you up on npm so I could do the same there but I couldn't find you. What your npm username? Thanks.

@Richienb
Copy link
Collaborator Author

@bchr02 It's richienb. I'll finish up the pr when exams are done.

@bchr02
Copy link
Owner

bchr02 commented Dec 7, 2020

Hi @Richienb any update? By the way, I just added you on npm. thank you.

@Richienb
Copy link
Collaborator Author

Richienb commented Dec 9, 2020

@bchr02 The rewrite is complete. I just need to figure out how to stub modules for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpError "Not found"
2 participants