Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: smart sessions timeframe policy #7

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

VGabriel45
Copy link
Contributor

@VGabriel45 VGabriel45 commented Jan 21, 2025

PR-Codex overview

This PR focuses on updating the session management policies in the smartSessionsValidator module, including adjustments to session validity timings and the introduction of new parameters for action policies.

Detailed summary

  • Updated CHANGELOG.md with version 0.0.31 and 0.0.30 changes.
  • Changed sessionValidUntil and sessionValidAfter to use Date.now() for accurate timing.
  • Added usageLimit and valueLimit in policy tests.
  • Modified getPermissionAction to include time frame policy data for user operations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@VGabriel45 VGabriel45 changed the title Chore/smart sessions timeframe policy chore: smart sessions timeframe policy Jan 21, 2025
@VGabriel45 VGabriel45 requested a review from joepegler January 21, 2025 12:55
Copy link

size-limit report 📦

Path Size
core (esm) 36.57 KB (+0.08% 🔺)
core (cjs) 45.94 KB (+0.15% 🔺)
bundler (tree-shaking) 523 B (0%)
paymaster (tree-shaking) 543 B (0%)

@joepegler
Copy link
Collaborator

I will merge this after rhinestone attest timerange policy across chains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants