fix: remediations. allow receive eth and withdraw stuck eth #195
livingrockrisesci.yml
on: push
Lint sources
39s
Unit tests
1m 25s
Annotations
3 errors and 12 warnings
|
Lint sources:
contracts/common/BiconomyTokenPaymasterErrors.sol#L87
Function order is incorrect, event definition can not go after custom error definition (line 82)
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L20
Unexpected import of console file
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L442
Function body contains 98 lines but allowed no more than 90 lines
|
|
Lint sources
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L7
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L10
global import of path account-abstraction/core/UserOperationLib.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L18
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L109
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L156
GC: Use Custom Errors instead of revert statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L163
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L171
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_paymasterId' should not start with _
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_value' should not start with _
|
|
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, pnpm/action-setup@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|