Merge pull request #38 from bcnmy/fix/remediations-chainlight-BTPMQ4-002 #200
livingrockrisesci.yml
on: push
Lint sources
24s
Unit tests
1m 14s
Annotations
2 errors and 10 warnings
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L20
Unexpected import of console file
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L425
Function body contains 98 lines but allowed no more than 90 lines
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L7
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L10
global import of path account-abstraction/core/UserOperationLib.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L18
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L109
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L156
GC: Use Custom Errors instead of revert statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L163
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L171
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_paymasterId' should not start with _
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_value' should not start with _
|