Merge branch 'develop' into fix/remediations-chainlight-BTPMQ4-005 #202
livingrockrisesci.yml
on: push
Lint sources
32s
Unit tests
1m 14s
Annotations
7 errors and 10 warnings
|
Lint sources:
contracts/common/BiconomyTokenPaymasterErrors.sol#L87
Function order is incorrect, event definition can not go after custom error definition (line 82)
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L8
imported name SafeERC20 is not used
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L21
Unexpected import of console file
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L107
Error message for require is too long: 43 counted / 32 allowed
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L274
Error message for require is too long: 43 counted / 32 allowed
|
|
Lint sources:
contracts/token/BiconomyTokenPaymaster.sol#L448
Function body contains 100 lines but allowed no more than 90 lines
|
|
Unit tests
Process completed with exit code 1.
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L7
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L10
global import of path account-abstraction/core/UserOperationLib.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L18
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L109
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L156
GC: Use Custom Errors instead of revert statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L163
GC: Use Custom Errors instead of require statements
|
|
Lint sources:
contracts/base/BasePaymaster.sol#L171
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/IERC20.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_paymasterId' should not start with _
|
|
Lint sources:
contracts/interfaces/IBiconomySponsorshipPaymaster.sol#L18
'_value' should not start with _
|