respond to PR comments

bcnmy · Oct 22, 2024 · fcc4c46 · fcc4c46
1 parent d2d96a5
commit fcc4c46
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/contracts/sponsorship/BiconomySponsorshipPaymaster.sol b/contracts/sponsorship/BiconomySponsorshipPaymaster.sol
@@ -282,14 +282,12 @@ contract BiconomySponsorshipPaymaster is
             if (prechargedAmount > adjustedGasCost) {
                 // If overcharged refund the excess
                 paymasterIdBalances[paymasterId] += (prechargedAmount - adjustedGasCost);
-                // here adjustedGasCost does not account for gasPenalty
-                emit GasBalanceDeducted(paymasterId, adjustedGasCost, premium);
             } else {
                 // deduct what needs to be deducted from paymasterId
-                paymasterIdBalances[paymasterId] -= (adjustedGasCost - prechargedAmount);
-                // here chargedAmount accounts for penalty with maxGasPenalty
-                emit GasBalanceDeducted(paymasterId, prechargedAmount, premium);
+                paymasterIdBalances[paymasterId] -= (adjustedGasCost - prechargedAmount);                
             }
+            // here adjustedGasCost does not account for gasPenalty. prechargedAmount accounts for penalty with maxGasPenalty
+            emit GasBalanceDeducted(paymasterId, adjustedGasCost, premium);
         }
     }