Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chainlight 005 // Introduce withdrawal delay and min deposit #27

Merged

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Oct 15, 2024

Fix this.

  • Introduce submit request / execute request pattern for paymaster id balances withdrawals. Delay can be set to 0 for trusted paymasterIds though

  • introduce min deposit.

  • Introduce code changes

  • Fix tests

@livingrockrises
Copy link
Contributor

livingrockrises commented Oct 15, 2024

let's merge below PR to develop first, take back merge and work on the test cases
https://github.com/bcnmy/gasdaddy/pull/28/files

1 similar comment
@livingrockrises
Copy link
Contributor

let's merge below PR to develop first, take back merge and work on the test cases
https://github.com/bcnmy/gasdaddy/pull/28/files

@filmakarov
Copy link
Collaborator Author

let's merge below PR to develop first, take back merge and work on the test cases https://github.com/bcnmy/gasdaddy/pull/28/files

looking at it

@livingrockrises livingrockrises marked this pull request as ready for review October 18, 2024 10:16
@wooz3k-t
Copy link

Here's a minor suggestion.

  • Emit an event in setTrustedPaymasterId(), setMinDeposit(), and withdrawEth().
  • Add require(_trustedPaymasterIds[paymasterId] != isTrusted) in setTrustedPaymasterId().

@livingrockrises
Copy link
Contributor

Here's a minor suggestion.

  • Emit an event in setTrustedPaymasterId(), setMinDeposit(), and withdrawEth().
  • Add require(_trustedPaymasterIds[paymasterId] != isTrusted) in setTrustedPaymasterId().

we thought these actions may not need event tracking. can still add @filmakarov

@filmakarov
Copy link
Collaborator Author

Here's a minor suggestion.

  • Emit an event in setTrustedPaymasterId(), setMinDeposit(), and withdrawEth().
  • Add require(_trustedPaymasterIds[paymasterId] != isTrusted) in setTrustedPaymasterId().

addressed here 36fb443

@livingrockrises livingrockrises merged commit 21525d8 into develop Oct 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants