fix:tests #28
Merged
fix:tests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmakarov
approved these changes
Oct 17, 2024
| PackedUserOperation[] memory ops = new PackedUserOperation[](1); | ||
| (PackedUserOperation memory userOp, bytes32 userOpHash) = createUserOp(ALICE, bicoPaymaster, priceMarkup); | ||
| (PackedUserOperation memory userOp, bytes32 userOpHash) = createUserOp(ALICE, bicoPaymaster, 1_100_000, 100_000); |
There was a problem hiding this comment.
same as above, name params for more readability
There was a problem hiding this comment.
was avoiding local vars :/
Co-authored-by: filmakarov <[email protected]>
Co-authored-by: filmakarov <[email protected]>
Co-authored-by: filmakarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revamp (WIP) test cases and helpers a bit to avoid running into stack too deep issues.
for further work on this repo,
keep these in mind
i. Bundling related parameters into struct - those are used repeatedly.
ii. Minimize number of local variables and identify areas where it can be block scoped.
iii. Offload intermediate variables into memory to avoid direct stack operations
iv. Review order of variable initialisation
v. can work on further breaking down complex functions.
Note that paymaster validation gas limit, callGasLimit, verificationGasLimit estimations are currently skipped. either ways they can not be accurate without using gas estimation package.
unaccountedGasCost should be kept appropriate value after testing, when there is premium to be charge unaccountedGas needs to be higher value (also depending on warm/cold slot of fee collector)