Temp remove post op cost and add tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,15 +145,19 @@ contract BiconomySponsorshipPaymaster is | |||
| function withdrawTo(address payable withdrawAddress, uint256 amount) external override nonReentrant { | |||
| if (withdrawAddress == address(0)) revert CanNotWithdrawToZeroAddress(); | |||
| uint256 currentBalance = paymasterIdBalances[msg.sender]; | |||
| require(amount <= currentBalance, "Sponsorship Paymaster: Insufficient funds to withdraw from gas tank"); | |||
| if (amount > currentBalance) { | |||
| revert InsufficientFundsInGasTank(); | |||
There was a problem hiding this comment.
make sure to add test cases
| abi.decode(context, (address, uint32, bytes32)); | ||
|
|
||
| uint256 balToDeduct = actualGasCost + postopCost * actualUserOpFeePerGas; | ||
| uint256 adjustedGasCost = (actualGasCost * dynamicAdjustment) / PRICE_DENOMINATOR; |
There was a problem hiding this comment.
dynamicAdjustment can be worded better.
|
|
||
| uint256 maxFeePerGas = userOp.unpackMaxFeePerGas(); | ||
| if (priceMarkup > 2e6 || priceMarkup == 0) { | ||
| revert InvalidPriceMarkup(); |
There was a problem hiding this comment.
make sure these are caught properly all the way bubbled up to entry point.
by writing negative test cases
| "Sponsorship Paymaster: paymasterId does not have enough deposit" | ||
| ); | ||
| if (effectiveCost > paymasterIdBalances[paymasterId]) { | ||
| revert InsufficientFundsForPaymasterId(); |
There was a problem hiding this comment.
write a test that catches this from entrypoint handleOps execution.
livingrockrises
approved these changes
Jul 8, 2024
livingrockrises
merged commit 31a4ea1
into
feat/paymaster-foundry-tests
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.