chore: distributed session keys #114
Conversation
size-limit report 📦
|
joepegler
force-pushed
the
feat/ss_dan
branch
from
58f0598 to
2ec5a92
Compare
joepegler
force-pushed
the
feat/ss_dan
branch
from
fc13ada to
1555e0b
Compare
| @@ -123,14 +123,14 @@ export const toSmartSessionsValidator = ( | |||
| getStubSignature: async () => | |||
| encodeSmartSessionSignature({ | |||
| mode, | |||
| permissionId, | |||
| permissionId: permissionIds[permissionIdIndex], | |||
There was a problem hiding this comment.
when getting a sig we only need one permissionId at a time. which represents a session
There was a problem hiding this comment.
need to check if there is case where it's making use of multiple already-enabled sessions in a single userop.
There was a problem hiding this comment.
so we can confirm it then only make an array? in this PR can you revert it
There was a problem hiding this comment.
In this pr the functionality hasn't changed. I've only paved the way for accommodating multiple permissionIds later.
There was a problem hiding this comment.
It's better that the type changes to this sooner rather than later. Right now if you create multiple permissionIds then only the first gets added to the module.
There was a problem hiding this comment.
If you'd prefer I can revert, but I don't see any harm in doing this now.
There was a problem hiding this comment.
hmm the module keeps active permission id single because for signature only one can be used at a time.
reverting is better only because we first check feasibility, ask @Fil then make changes.
| @@ -123,14 +123,14 @@ export const toSmartSessionsValidator = ( | |||
| getStubSignature: async () => | |||
| encodeSmartSessionSignature({ | |||
| mode, | |||
| permissionId, | |||
| permissionId: permissionIds[permissionIdIndex], | |||
| enableSessionData, | |||
| signature: DUMMY_ECDSA_SIG | |||
| }), | |||
| signUserOpHash: async (userOpHash: Hex) => | |||
| encodeSmartSessionSignature({ | |||
There was a problem hiding this comment.
add on to above comments, in module-sdk also encodeSmartSessionSignature uses single permissionId
| @@ -102,7 +102,7 @@ export const parseModule = < | |||
| chain extends Chain | undefined | |||
| >( | |||
| client: Client<Transport, chain, TModularSmartAccount> | |||
| ) => { | |||
| ): AnyData => { | |||
There was a problem hiding this comment.
what does parseModule do?
There was a problem hiding this comment.
It's a helper meant only for internal use. Not to be used externally really. It's a helper that pulls out the active module instance from the nexusClient.
|
Good points re permissionIds. I've created a ticket for your suggestion: #116 |
joepegler
force-pushed
the
feat/ss_dan
branch
from
1555e0b to
19baeaa
Compare
PR-Codex overview
This PR focuses on updating the
@biconomy/sdkpackage to version0.0.10, introducing distributed session keys and enhancing smart session functionalities. It includes various improvements in error handling, session management, and code structure.Detailed summary
package.jsonto0.0.10.KEY_GEN_DATA_NOT_FOUNDandSIGNATURE_NOT_FOUNDerror messages inConstants.ts.permissionIdtopermissionIdsin several files to support multiple permissions.createNexusSessionClientto directly returncreateNexusClient.usePermissionto usecallsinstead ofactions.useDistributedPermissionfor executing multiple actions in a session.toSmartSessionsValidator.dan.dx.test.ts.