Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retain action data in session payload #141

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Dec 5, 2024

PR-Codex overview

This PR focuses on enhancing the smartSessionsValidator by refining session data structures, integrating a description field, and improving the handling of session permissions. It also updates tests to reflect these changes.

Detailed summary

  • Added a description field to UsePermissionModuleData.
  • Merged permissionIds into GrantPermissionActionReturnParams.
  • Updated session data handling in multiple test files to use the new structure.
  • Renamed variables for clarity (e.g., zippedSessionDatum to stringifiedSessionDatum).
  • Improved error handling and session creation logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joepegler joepegler force-pushed the feat/retain_session_action branch from 3f3fc7c to e1a7796 Compare December 5, 2024 11:30
Copy link

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
core (esm) 14.23 KB (+0.21% 🔺)
core (cjs) 20.14 KB (+0.54% 🔺)
bundler (tree-shaking) 543 B (0%)
paymaster (tree-shaking) 123 B (0%)

@joepegler joepegler force-pushed the feat/retain_session_action branch from e1a7796 to 549e0cb Compare December 5, 2024 11:32
@joepegler joepegler force-pushed the feat/retain_session_action branch from 549e0cb to df169a9 Compare December 5, 2024 11:33
@joepegler joepegler requested a review from VGabriel45 December 5, 2024 12:21
@joepegler joepegler merged commit 8d6e0a4 into develop Dec 6, 2024
5 checks passed
@joepegler joepegler deleted the feat/retain_session_action branch December 6, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant