Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix getAddress #142

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: fix getAddress #142

merged 1 commit into from
Dec 5, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Dec 5, 2024

PR-Codex overview

This PR updates the version of the @biconomy/sdk package and improves the getAddress() function in the src/sdk/account/toNexusAccount.ts file to enhance error handling and address retrieval logic.

Detailed summary

  • Updated version in package.json from 0.0.12 to 0.0.13.
  • Modified the getInitCode function description to clarify its purpose.
  • Enhanced error handling in getAddress():
    • Introduced accountAddressFromError for better clarity.
    • Added logic to retrieve the address from the factory contract using computeAccountAddress.
    • Included a check to ensure the retrieved address is not a zero address before returning it.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
core (esm) 14.3 KB (+0.71% 🔺)
core (cjs) 20.15 KB (+0.58% 🔺)
bundler (tree-shaking) 543 B (0%)
paymaster (tree-shaking) 123 B (0%)

@joepegler joepegler merged commit f1157cb into develop Dec 5, 2024
5 checks passed
@joepegler joepegler deleted the hotfix/getAddress branch December 5, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant