Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue with maxFeePerGas and maxPriorityFeePerGas being 0 #30

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

VGabriel45
Copy link
Collaborator

@VGabriel45 VGabriel45 commented Mar 21, 2024

PR-Codex overview

This PR updates sendTransaction and sendTransactions functions to remove unnecessary toHex conversions and import types from "viem".

Detailed summary

  • Removed toHex conversions in sendTransaction and sendTransactions
  • Imported types from "viem" in both functions

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

size-limit report 📦

Path Size
core (esm) 4.84 KB (-0.88% 🔽)
core (cjs) 10.18 KB (-0.08% 🔽)
smartAccount (tree-shaking) 2.91 KB (0%)
bundler (tree-shaking) 1.63 KB (0%)
paymaster (tree-shaking) 372 B (0%)

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 93.31% (🎯 80%) 3380 / 3622
🟢 Statements 93.31% (🎯 80%) 3380 / 3622
🟢 Functions 82.02% (🎯 70%) 73 / 89
🟢 Branches 67.51% (🎯 60%) 133 / 197
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/accounts/actions/sendTransaction.ts 96.89% 16.66% 100% 96.89% 89-90, 97-98
src/accounts/actions/sendTransactions.ts 97.08% 28.57% 100% 97.08% 94-95, 100-101
Generated in workflow #120

@joepegler joepegler merged commit 4e1a2a1 into main Mar 21, 2024
5 checks passed
@joepegler joepegler deleted the fix-feeValues branch March 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants