Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sma-747 tsdoc fixes #34

Merged
merged 3 commits into from
Mar 25, 2024
Merged

chore: sma-747 tsdoc fixes #34

merged 3 commits into from
Mar 25, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Mar 25, 2024

PR-Codex overview

This PR focuses on restructuring exports, updating types, and reorganizing modules.

Detailed summary

  • Restructured exports in multiple files
  • Updated types and added new type definitions
  • Reorganized modules and actions across different directories

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 25, 2024

SMA-747 Bring tsDoc up to date

  • Properly write the returns types of our new functions so that our tsdoc becomes useful
  • Team up with Himanshu so she can take on ownership of the human readable docs

Copy link

github-actions bot commented Mar 25, 2024

size-limit report 📦

Path Size
core (esm) 6.63 KB (+15.99% 🔺)
core (cjs) 12.03 KB (+3.43% 🔺)
smartAccount (tree-shaking) 2.91 KB (-0.27% 🔽)
bundler (tree-shaking) 2.43 KB (+0.13% 🔺)
paymaster (tree-shaking) 1.4 KB (+0.43% 🔺)

Copy link

github-actions bot commented Mar 25, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 93.83% (🎯 90%) 4473 / 4767
🟢 Statements 93.83% (🎯 80%) 4473 / 4767
🟢 Functions 82.69% (🎯 80%) 86 / 104
🟢 Branches 68.4% (🎯 60%) 171 / 250
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/index.ts 100% 100% 100% 100%
src/accounts/index.ts 100% 100% 100% 100%
src/accounts/actions/index.ts 100% 100% 100% 100%
src/accounts/actions/sendTransaction.ts 96.87% 28.57% 100% 96.87% 88-89, 96-97
src/accounts/actions/sendTransactions.ts 96.87% 28.57% 100% 96.87% 85-86, 91-92
src/accounts/actions/sendUserOperation.ts 100% 66.66% 100% 100%
src/accounts/biconomyV2/signerToSmartAccount.ts 96.31% 72.97% 77.77% 96.31% 227-228, 276-278, 285-286, 302-304, 411-412, 455-459
src/bundler/index.ts 100% 100% 100% 100%
src/bundler/actions/index.ts 100% 100% 100% 100%
src/bundler/actions/sendUserOperation.ts 100% 100% 100% 100%
src/bundler/utils/helpers.ts 95.91% 60% 100% 95.91% 14-15, 18-19
src/bundler/utils/types.ts 100% 100% 100% 100%
src/client/createSmartAccountClient.ts 100% 100% 100% 100%
src/client/index.ts 100% 100% 100% 100%
src/client/decorators/bundler.ts 96.04% 100% 70% 96.04% 230-237, 239, 242
src/client/decorators/index.ts 100% 100% 100% 100%
src/client/decorators/smartAccount.ts 100% 100% 100% 100%
src/client/utils/types.ts 100% 100% 100% 100%
src/errors/index.ts 100% 100% 100% 100%
src/modules/index.ts 100% 100% 100% 100%
src/paymaster/index.ts 100% 100% 100% 100%
Generated in workflow #142

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@808aa5d). Click here to learn what that means.

❗ Current head ac7b718 differs from pull request most recent head 7a195fb. Consider uploading reports for the commit 7a195fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   93.87%           
==========================================
  Files              ?       56           
  Lines              ?     4767           
  Branches           ?      231           
==========================================
  Hits               ?     4475           
  Misses             ?      292           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepegler joepegler merged commit 312ab12 into develop Mar 25, 2024
5 checks passed
@joepegler joepegler deleted the chore/SMA-747_tsdoc branch March 25, 2024 15:36
joepegler added a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant